[RFC] Remove unnecessary permissions

Note: We are moving the topics of this forum and it will be deleted at some point

Publish your own request for comments/change or patches for the next version of phpBB. Discuss the contributions and proposals of others. Upcoming releases are 3.2/Rhea and 3.3.
Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: [RFC] Remove unnecessary permissions

Post by Oleg » Sat Dec 24, 2011 6:43 am

How about this one:

acl_u_pm_emailpm Can e-mail private messages

It does not look like it's even used anywhere.

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] Remove unnecessary permissions

Post by imkingdavid » Sat Dec 24, 2011 7:20 pm

Oleg wrote:How about this one:

acl_u_pm_emailpm Can e-mail private messages

It does not look like it's even used anywhere.
You're right. It's only in 3 files:
  • develop/add_permissions.php
  • install/schemas/schema_data.sql
  • language/en/acp/permissions_phpbb.php
It isn't actually being used, and could be removed without consequence, afaik.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] Remove unnecessary permissions

Post by imkingdavid » Sat Dec 24, 2011 7:21 pm

t_backoff wrote:
imkingdavid wrote:
Oleg wrote:u_chgcensors - if one runs a board for pg-13 audience one may want to prohibit everyone from seeing censored words. Also, there are boards in competitive settings where they censor their competition, in such cases admins may not want to allow users to uncensor the board.
If you want to prohibit it, disable the setting, but there's no need for a permission as well.
No, because as an administrator, I may want to see the uncensored words while prohibiting normal users from seeing them. I feel really strongly about this permission!
Fair enough, I'll leave it in. I don't feel all too strongly about removing it, I just personally didn't see a purpose for it. But if other people actually find a use for it, then it shouldn't be removed.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: [RFC] Remove unnecessary permissions

Post by Oleg » Sun Dec 25, 2011 7:52 pm

There is a ticket for the email pm permission: http://tracker.phpbb.com/browse/PHPBB3-9568

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] Remove unnecessary permissions

Post by imkingdavid » Sun Dec 25, 2011 8:48 pm

Oleg wrote:There is a ticket for the email pm permission: http://tracker.phpbb.com/browse/PHPBB3-9568
Well I just removed it in my patch, but I can add it back if we're planning on adding the feature. Is that the plan?
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: [RFC] Remove unnecessary permissions

Post by Oleg » Sun Dec 25, 2011 9:10 pm

Do you know where one forwards pm to email in the ui?

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] Remove unnecessary permissions

Post by imkingdavid » Sun Dec 25, 2011 9:13 pm

Oleg wrote:Do you know where one forwards pm to email in the ui?
It is currently not implemented, afaik. Which is why it has been removed.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: [RFC] Remove unnecessary permissions

Post by Oleg » Sun Dec 25, 2011 11:54 pm

http://tracker.phpbb.com/browse/PHPBB3- ... ment-33890 suggests that the functionality to forward pm to email exists, and is just not checked against permissions. Or am I misunderstanding this?

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] Remove unnecessary permissions

Post by imkingdavid » Mon Dec 26, 2011 12:40 am

Oleg wrote:http://tracker.phpbb.com/browse/PHPBB3- ... ment-33890 suggests that the functionality to forward pm to email exists, and is just not checked against permissions. Or am I misunderstanding this?
If it was there it would be similar to the Email friend functionality on viewtopic, which is an envelope icon next to the print icon above the Logout link. However, only the print icon shows there. I'm not sure if the page is there but just not linked to or if the entire page does not exist.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] Remove unnecessary permissions

Post by imkingdavid » Mon Dec 26, 2011 3:47 pm

For the record, all suggested permissions except u_chgcensors has been removed. If anyone thinks any others are unnecessary or if you think one that was removed is necessary (or was not removed properly), let me know and I'll see about fixing it.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

Post Reply