[RFC] Refactor adm_back_link usage

Note: We are moving the topics of this forum and it will be deleted at some point

Publish your own request for comments/change or patches for the next version of phpBB. Discuss the contributions and proposals of others. Upcoming releases are 3.2/Rhea and 3.3.
Post Reply
Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

[RFC] Refactor adm_back_link usage

Post by Oleg »

Currently most of ACP is unusable from a script due to adm_back_link calls which might be doing or require user/session setup or other interactive stuff.

The code should be rewritten to separate actual work from UI, such that the work code can be scriptable.

User avatar
bantu
3.0 Release Manager
3.0 Release Manager
Posts: 557
Joined: Thu Sep 07, 2006 11:22 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC] Refactor adm_back_link usage

Post by bantu »

Absolutely.

Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: [RFC] Refactor adm_back_link usage

Post by Oleg »

It just occurred to me that adm_back_link calls can probably be trivially replaced with exception throwing.

igorw
Registered User
Posts: 500
Joined: Thu Jan 04, 2007 11:47 pm

Re: [RFC] Refactor adm_back_link usage

Post by igorw »

Just because we're already abusing trigger_error for displaying messages to the user does not mean we should now use exceptions for the same thing. If we fix it, we should fix it properly.

Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: [RFC] Refactor adm_back_link usage

Post by Oleg »

Do you mean with special return values?

User avatar
brunoais
Registered User
Posts: 964
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC] Refactor adm_back_link usage

Post by brunoais »

how are we about this?

Post Reply