[RFC] Show New Topic Button on Viewtopic

Note: We are moving the topics of this forum and it will be deleted at some point

Publish your own request for comments/change or patches for the next version of phpBB. Discuss the contributions and proposals of others. Upcoming releases are 3.2/Rhea and 3.3.
User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1823
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [RFC] Show New Topic Button on Viewtopic

Post by DavidIQ » Tue Jul 12, 2011 2:12 am

I don't like the idea of a button either. Perhaps a link under the Reply button might be ok sort of how the Reply All feature is in PMs.
Image

User avatar
callumacrae
Former Team Member
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: [RFC] Show New Topic Button on Viewtopic

Post by callumacrae » Wed Jul 13, 2011 12:22 pm

Preview:

Code: Select all

var buttons = document.getElementsByClassName('buttons');
for (var i = 0; i < buttons.length; i++)
{
  buttons[i].innerHTML += '<div class="post-icon" title="Post a new topic"><a href="./posting.php?mode=post&f=108"><span></span>Post a new topic</a></div>';
}
It doesn't look bad, but I don't like it - it's not really necessary and it's just yet another button.

~Callum
Made by developers, for developers!
My blog

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1823
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [RFC] Show New Topic Button on Viewtopic

Post by DavidIQ » Wed Jul 13, 2011 1:55 pm

That JavaScript is rather bleh...what happened to your jQuery-Fu?
Image

User avatar
callumacrae
Former Team Member
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: [RFC] Show New Topic Button on Viewtopic

Post by callumacrae » Wed Jul 13, 2011 3:26 pm

I can't use jQuery when it isn't loaded ;)

EDIT: However, if it were:

Code: Select all

$('.buttons').append('<div class="post-icon"><a href="./posting.php?mode=post&f=108"><span></span>Post a new topic</a></div>');
Last edited by callumacrae on Wed Jul 13, 2011 3:38 pm, edited 1 time in total.
Made by developers, for developers!
My blog

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1823
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [RFC] Show New Topic Button on Viewtopic

Post by DavidIQ » Wed Jul 13, 2011 3:36 pm

That makes no sense. You're doing the above before the page loads? That would be the only time jQuery wouldn't be available and it would make no sense to do what you posted at that point. Besides that why would you even consider creating this button using javascript?

P.S. you do realize jQuery is being added in 3.1 right?
Image

User avatar
callumacrae
Former Team Member
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: [RFC] Show New Topic Button on Viewtopic

Post by callumacrae » Wed Jul 13, 2011 3:40 pm

DavidIQ wrote:That makes no sense. You're doing the above before the page loads? That would be the only time jQuery wouldn't be available and it would make no sense to do what you posted at that point. Besides that why would you even consider creating this button using javascript?

P.S. you do realize jQuery is being added in 3.1 right?
I put all JavaScript in the page footer. It isn't how I think it should be added, it is just showing people who can't be bothered to edit prosilver what it looks like.

Yes xD
Made by developers, for developers!
My blog

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1823
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [RFC] Show New Topic Button on Viewtopic

Post by DavidIQ » Wed Jul 13, 2011 3:50 pm

I don't remember seeing anyone say jQuery would go in the footer. It wouldl likely go in the header where we have all other javascript...

Back on topic: I still don't quite like the idea.
Image

User avatar
AmigoJack
Registered User
Posts: 103
Joined: Wed May 04, 2011 7:47 pm
Location: グリーン ヒル ゾーン
Contact:

Re: [RFC] Show New Topic Button on Viewtopic

Post by AmigoJack » Sun Aug 07, 2011 11:45 pm

imkingdavid wrote:The reason for removing it, as I understand it, was that too many people would click the New Topic button instead of New Reply when viewing a topic so they would start a new topic with their reply. Yes, it would be nice to have both buttons if people were more observant, but they aren't.
Good objection. On my board the "new topic" button while viewing a topic is a real benefit, but looking to the general phpBB user I'm sure there would be more problems when implementing this as default.

User avatar
Dragosvr92
Registered User
Posts: 624
Joined: Tue May 31, 2011 12:08 pm
Location: Romania
Contact:

Re: [RFC] Show New Topic Button on Viewtopic

Post by Dragosvr92 » Mon Aug 08, 2011 5:20 am

I Disagree ! My style had the post new topic in the viewtopic page and it confused me more. i never used it.
You are inside the topic and you are going to post a reply, not a new topic.
Previous user: TheKiller
Avatar on Memberlist 1.0.3

Post Reply