phpBB

Development Discussion Board

phpBB's testing ground of bleeding edge code
Advanced search

[RFC] More secure hashing

Publish your own request for comments or patches for the next version of phpBB. Discuss the contributions and proposals of others. Upcoming releases are 3.1/Ascraeus and 3.2/Arsia.

Re: [RFC] Update password hashing algorithm

Postby bantu » Sat Mar 31, 2012 6:33 pm

MartinTruckenbrodt wrote:Hello bantu,
no, this doesn't increase security.

How? Source for this statement?

It clearly does. When there is a SQL injection I get all the salts and all the user password hashes.

Your proposal:
1 salt
u user hashes

I take my dictionary with w words and hash all the words with the hash function and the one salt.

Complexity for hashing all words: 1 * w
Then I compare the results with all u user hashes.

Per-password-hashes:
u salts
u user hashes

Again, I take my dictionary with w words and hash all the words with the hash function, but have to do this for every salt.

Complexity for hashing all words: u * w
Then I compare the results with all u user hashes.

Also, the salt changes when the password changes.

MartinTruckenbrodt wrote:I think it's more secure to have one salt in CONFIG_TABLE and all passwords in USERS_TABLE insteat of saving all salts and all passwords together in one table USERS_TABLE.

Yeah, you can think that if you want. Again, please read up on Password Hashing and Salting. Buy a good crypto book or something.

MartinTruckenbrodt wrote:Still I don't believe that there are rainbow tables with hashes for random strings. Please show me a source for this statement.

Use your favorite search engine and search for "rainbow table".
User avatar
bantu
3.0 Release Manager
3.0 Release Manager
 
Posts: 439
Joined: Thu Sep 07, 2006 11:22 am
Location: Karlsruhe, Germany

Re: [RFC] Update password hashing algorithm

Postby brunoais » Sat Mar 31, 2012 7:21 pm

Anyway, the best option is a boardwide salt and a user salt.
I actually don't know how better it is against a user salt nevertheless it is better. And we could save that salt in a harder-to-find place like the config.php. It's not full proof but it's harder to reach because the attacker would need to attack the DB and the file system in order to get that salt.
brunoais
Registered User
 
Posts: 627
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC] Update password hashing algorithm

Postby callumacrae » Sat Mar 31, 2012 7:43 pm

brunoais wrote:Anyway, the best option is a boardwide salt and a user salt.
I actually don't know how better it is against a user salt nevertheless it is better. And we could save that salt in a harder-to-find place like the config.php. It's not full proof but it's harder to reach because the attacker would need to attack the DB and the file system in order to get that salt.

Yeah, this.
"In JavaScript, there is a beautiful, elegant, highly expressive language that is buried under a steaming pile of good intentions and blunders"
—Douglas Crockford

View my MOD, phpBB Mobile
User avatar
callumacrae
Website Team
Website Team
 
Posts: 883
Joined: Tue Apr 27, 2010 9:37 am
Location: England

Previous

Return to [3.x] RFCs

Who is online

Users browsing this forum: Google [Bot] and 17 guests