[RFC|Accepted] Updated BBcode engine

Note: We are moving the topics of this forum and it will be deleted at some point

Publish your own request for comments/change or patches for the next version of phpBB. Discuss the contributions and proposals of others. Upcoming releases are 3.2/Rhea and 3.3.
Post Reply
User avatar
Meis2M
Registered User
Posts: 411
Joined: Fri Apr 23, 2010 10:18 am
Contact:

Re: [RFC|Accepted] Updated BBcode engine

Post by Meis2M » Sun Mar 16, 2014 7:05 pm

if it is complete so why not merge into 3.1 ? :D

User avatar
JoshyPHP
Registered User
Posts: 348
Joined: Fri Jul 08, 2011 9:43 pm

Re: [RFC|Accepted] Updated BBcode engine

Post by JoshyPHP » Sun Mar 16, 2014 8:11 pm

EXreaction wrote:As far as I know, it is complete.
It is in the sense that you can checkout my branch and not notice any loss of functionality. It's a "complete" replacement, and I try to pull changes from develop at least a couple of times a month to prevent bitrot too.

As a feature, I will consider it complete when phpBB will be able to fully exploit the library.

User avatar
nickvergessen
Former Team Member
Posts: 733
Joined: Sun Oct 07, 2007 11:54 am
Location: Stuttgart, Germany
Contact:

Re: [RFC|Accepted] Updated BBcode engine

Post by nickvergessen » Sun Mar 16, 2014 8:14 pm

Meis2M wrote:if it is complete so why not merge into 3.1 ? :D
Because we want to get 3.1 finished and not restart into the cycle of development which we do all the time which is always delaying stuff.
Member of the Development-TeamNo Support via PM

User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

Re: [RFC|Accepted] Updated BBcode engine

Post by EXreaction » Sun Mar 16, 2014 11:04 pm

Meis2M wrote:if it is complete so why not merge into 3.1 ? :D
Because we want to keep 3.1 stable and get it finished, large changes take a long time to review and typically do introduce some major bugs and result in delaying 3.1 even more.

I plan on reviewing this to merge into the 3.2 branch as soon as it's created.

User avatar
naderman
Product Manager
Product Manager
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC|Accepted] Updated BBcode engine

Post by naderman » Thu Mar 20, 2014 10:11 am

EXreaction wrote:I plan on reviewing this to merge into the 3.2 branch as soon as it's created.
In that case let's create it, as we were simply waiting on something that we wanted to merge into it to create it.

User avatar
rfdy
Registered User
Posts: 45
Joined: Wed Apr 16, 2014 2:28 pm

Re: [RFC|Accepted] Updated BBcode engine

Post by rfdy » Thu Jun 05, 2014 3:03 pm

I'm late to this thread, but will the new BBCode parser allow extensions to define custom codes? Currently only simple search/replace type codes can be added through the ACP, but for more complicated codes where a callback function is needed, this approach doesn't work.

For example, if I want an extension that augments the current quote functionality, it'd mean removing the quote bbcode from the list (ie. $this->bbcodes in bbcode_firstpass class), with our own custom rule with a different callback.

Will that be possible with the new parser??

Thanks!

User avatar
brunoais
Registered User
Posts: 958
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC|Accepted] Updated BBcode engine

Post by brunoais » Thu Jun 05, 2014 4:52 pm

Yes.
To be more precise, all BBCodes will be moved to custom BBCodes with the new parser.

Post Reply