[RFC] PDO / third party DBAL

Note: We are moving the topics of this forum and it will be deleted at some point

Publish your own request for comments/change or patches for the next version of phpBB. Discuss the contributions and proposals of others. Upcoming releases are 3.2/Rhea and 3.3.
User avatar
A_Jelly_Doughnut
Registered User
Posts: 1780
Joined: Wed Jun 04, 2003 4:23 pm

Re: [RFC] PDO / third party DBAL

Post by A_Jelly_Doughnut » Sun May 02, 2010 12:10 am

Unknown Bliss wrote:I think this would probably be a too bigger change for 3.1 personally.
EXreaction wrote:Doesn't this seem a bit much for 3.1?

We don't want to end up with another 3.2...the whole point here was to go with more frequent, less significant (change-wise), feature additions. Significant rewrites that are not required for the feature additions should not be done IMO.
I agree. For me, the benefits are minimal (essentially adding support for prepared statements, which we can clearly do without), and the cost is a whole lot of hours (even if evil3 is volunteering his time)

If I were writing something from the ground up, I'd be singing a different tune.
A_Jelly_Doughnut

User avatar
naderman
Product Manager
Product Manager
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC] PDO / third party DBAL

Post by naderman » Sun May 02, 2010 12:24 am

Honestly I think it doesn't matter. As long as it doesn't change the API there's no downside to having this available. While I wouldn't put any focus on this for 3.1, there's nothing wrong with working on it. Whether it will end up going into 3.1 or 3.2, we can decide later. We should be discussing the content of the proposal and practical implications, not who thinks this is something for 3.1 and who does not.

User avatar
ToonArmy
Registered User
Posts: 335
Joined: Fri Mar 26, 2004 7:31 pm
Location: Bristol, UK
Contact:

Re: [RFC] PDO / third party DBAL

Post by ToonArmy » Sun May 02, 2010 2:03 am

naderman wrote:Honestly I think it doesn't matter. As long as it doesn't change the API there's no downside to having this available. While I wouldn't put any focus on this for 3.1, there's nothing wrong with working on it. Whether it will end up going into 3.1 or 3.2, we can decide later. We should be discussing the content of the proposal and practical implications, not who thinks this is something for 3.1 and who does not.
Exactly, anything that doesn't make its way into 3.1 may make its way into 3.2 or 3.x if it's ready for the cut off date we can consider inclusion otherwise it's totally irrelevant anyway.
Chris SmithBlogXMOOhlohArea51WikiNo support via PM/IM
Image

User avatar
igorw
Registered User
Posts: 500
Joined: Thu Jan 04, 2007 11:47 pm

Re: [RFC] PDO / third party DBAL

Post by igorw » Sun May 09, 2010 2:34 pm

Warning, rant ahead.

Anybody ever tried installing phpBB on something else than MySQL? It's not fun. What happens is all your real error messages get suppressed (using @) and instead you get messages such as "not an error" (sqlite) or "no error message given" (postgres). This is one of the things I'm trying to improve with the initiative.

To fix that with the current drivers you'd have to set a special error handler to collect the error messages or use output buffering to suppress and store them.

Another thing that is utterly broken is the use of error suppressions on functions that might not exist. If you migrate to a new host and forgot to install/enable php's mysql(i) extension you will receive a blank page and no clue as to why. I once spent half an hour looking for this because the framework I was using had the same disease.

</rant>

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1731
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [RFC] PDO / third party DBAL

Post by DavidIQ » Sun May 09, 2010 2:39 pm

eviL3 wrote:Anybody ever tried installing phpBB on something else than MySQL? It's not fun. What happens is all your real error messages get suppressed (using @) and instead you get messages such as "not an error" (sqlite) or "no error message given" (postgres).
Add blank/white page with MS SQL Server or even "Service Unavailable"...
Image

DrStrangelove
Registered User
Posts: 13
Joined: Thu Jul 01, 2010 3:33 pm

Re: [RFC] PDO / third party DBAL

Post by DrStrangelove » Sat Jul 10, 2010 1:41 pm

eviL3 wrote:Anybody ever tried installing phpBB on something else than MySQL? It's not fun.
Now that I can believe. Whatever the database backend should be I trust the developers to make a good decision. But one thing seems to be true, other database backends than mysql doesn't seem work well. Why isn't sqlite3 supported yet? With the quality of shared hosting as it is today I'd say it is essential (!) to have a working sqlite3 backend by the release of phpbb 3.1.

sqlite as you know is an embedded database which in php runs in the same process, this of course makes it immune to problems with poor database connectivity which is a big problem in the hosting business. most ISPs, even big ones, doesn't have any good way to ensure fairly allocated resources, this is especially true for databases (!).

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1731
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [RFC] PDO / third party DBAL

Post by DavidIQ » Sun Jul 11, 2010 12:22 pm

DrStrangelove wrote:But one thing seems to be true, other database backends than mysql doesn't seem work well.
I've been using phpBB off of Microsoft SQL Server for a very long time and I've never had any issues...
Image

User avatar
A_Jelly_Doughnut
Registered User
Posts: 1780
Joined: Wed Jun 04, 2003 4:23 pm

Re: [RFC] PDO / third party DBAL

Post by A_Jelly_Doughnut » Tue Jul 13, 2010 9:13 pm

DrStrangelove wrote: Why isn't sqlite3 supported yet?
sqlite3 didn't exist when phpBB3 was released.

There's no one working on an sqlite3 DBAL layer (AFAIK) for phpBB 3.1. As far as I can remember, you're the only person to bring it up in the last six months or so.
A_Jelly_Doughnut

User avatar
rxu
Registered User
Posts: 124
Joined: Tue Apr 04, 2006 4:28 pm
Contact:

Re: [RFC] PDO / third party DBAL

Post by rxu » Wed Jul 14, 2010 1:08 pm

A_Jelly_Doughnut wrote:There's no one working on an sqlite3 DBAL layer
Well, ~2 years ago one of our board members has posted working approach for phpBB 3.0.x sqlite3 support (the page is in Russian, but can be translated) :)
AFAIK he keeps it up to date; never tested it, but the man says it's working.
Image

User avatar
igorw
Registered User
Posts: 500
Joined: Thu Jan 04, 2007 11:47 pm

Re: [RFC] PDO / third party DBAL

Post by igorw » Wed Jul 14, 2010 1:36 pm

The phpBB.com topic was locked: http://www.phpbb.com/community/viewtopi ... &t=1059695 I actually tried to get him to make a proper patch out of it.

Post Reply