[RFC|Accepted] Pre-Compile Template Includes

Note: We are moving the topics of this forum and it will be deleted at some point

Publish your own request for comments/change or patches for the next version of phpBB. Discuss the contributions and proposals of others. Upcoming releases are 3.2/Rhea and 3.3.
User avatar
MichaelC
Development Team
Development Team
Posts: 889
Joined: Thu Jan 28, 2010 6:29 pm

Re: [RFC] Pre-Compile Template Includes

Post by MichaelC »

eviL3 wrote:Has been answered a few posts above: viewtopic.php?p=207531#p207531
Oh yeh, sorry missed that.
Formerly known as Unknown Bliss
psoTFX wrote: I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"
No unsolicited PMs please except for quotes.

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] Pre-Compile Template Includes

Post by imkingdavid »

I think that this would be a great idea. I know firsthand how difficult it is to update multiple styles to support even a couple MODs. Having the template edits compiled through includes and PHP would be a great alternative.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

igorw
Registered User
Posts: 500
Joined: Thu Jan 04, 2007 11:47 pm

Re: [RFC] Pre-Compile Template Includes

Post by igorw »

I like the proposal. It would allow injecting template INCLUDE statements to make the injected template code style-independent. Thumbs up.

Would there be any way to control the order in which the template code is injected? Would the proposed hook priorities allow that?

User avatar
Kellanved
Former Team Member
Posts: 407
Joined: Sun Jul 30, 2006 4:59 pm
Location: Berlin

Re: [RFC] Pre-Compile Template Includes

Post by Kellanved »

eviL3 wrote: Would there be any way to control the order in which the template code is injected? Would the proposed hook priorities allow that?
Precisely :D
No support via PM.
Trust me, I'm a doctor.

Jhong
Registered User
Posts: 50
Joined: Tue Dec 26, 2006 3:28 pm

Re: [RFC] Pre-Compile Template Includes

Post by Jhong »

Excellent idea. Many mods use the same areas and template edits.

Some off the top of my head I would find useful in overall_header and overall_footer:

VERY_TOP
META
EARLY_SCRIPTS
HEAD_END
BODY_BEGIN
EXTRA_NAVIGATION
BEFORE_COPYRIGHT
AFTER_COPYRIGHT
BODY_END

Post Reply