Created a PR for this.
https://github.com/phpbb/phpbb/pull/3673
-javiexin
Search found 90 matches
- Sun May 31, 2015 11:17 am
- Forum: [3.x] Tickets Discussion
- Topic: PHPBB3-13853 Cannot completey add a new profile field type
- Replies: 1
- Views: 9316
- Thu May 28, 2015 8:54 pm
- Forum: [3.x] Tickets Discussion
- Topic: PHPBB3-13867 - Profile field types need an enable/disable mechanism
- Replies: 4
- Views: 13485
Re: PHPBB3-13867 - Profile field types need an enable/disable mechanism
Ok, I have submitted a pull request solving this issue: https://github.com/phpbb/phpbb/pull/3656 The mechanism used is similar to the one used for notifications. The profilefields/manager class adds methods to be called on extension disable, purge and enable steps. The use from extensions is extreme...
- Wed May 27, 2015 10:01 pm
- Forum: [3.x] Tickets Discussion
- Topic: PHPBB3-13867 - Profile field types need an enable/disable mechanism
- Replies: 4
- Views: 13485
Re: PHPBB3-13867 - Profile field types need an enable/disable mechanism
Finally, I have implemented a self-contained workaround, that you may see here: https://github.com/javiexin/multiselpf/blob/master/ext.php However, this is still not 100% error free, and there are traces of what is being done, and corner cases where the forum may be forced to break. So, I would kind...
- Tue May 26, 2015 12:13 am
- Forum: [3.x] Tickets Discussion
- Topic: PHPBB3-13867 - Profile field types need an enable/disable mechanism
- Replies: 4
- Views: 13485
Re: PHPBB3-13867 - Profile field types need an enable/disable mechanism
Thanks for the pointer to this new useful example VSE. I have almost all the problem clear now. Most things can be handled from within the extension itself (inactivate fields on extension disable, delete field on extension removal, activate fields on extension enable), with one exception: in file in...
- Mon May 25, 2015 4:45 pm
- Forum: [3.x] Tickets Discussion
- Topic: PHPBB3-13867 - Profile field types need an enable/disable mechanism
- Replies: 4
- Views: 13485
PHPBB3-13867 - Profile field types need an enable/disable mechanism
Issue in the tracker: https://tracker.phpbb.com/browse/PHPBB3-13867?filter=10292 If an extension defines a new Profile Field type, it needs some kind of mechanism to enable, disable and purge data of this particular Profile Field type, to avoid cases of left profile fields based on no-longer existin...
- Tue May 19, 2015 12:11 pm
- Forum: [3.x] Tickets Discussion
- Topic: PHPBB3-13853 Cannot completey add a new profile field type
- Replies: 1
- Views: 9316
PHPBB3-13853 Cannot completey add a new profile field type
There is no way to insert potentially required code in adm/style/acp_profile.html STEP 1 (lines 106 to 128) as code is hardcoded for the existing types. Given the way profilefields work, using an event would be (in my opinion) a bad resolution to this. A flexible schema, similar to the one used for ...
- Mon May 18, 2015 9:46 am
- Forum: [3.x] Discussion
- Topic: Replacing blocks of template code
- Replies: 2
- Views: 4488
Re: Replacing blocks of template code
Thanks, I didn't know about it, and yes, it is very related.
However, there is no conclusion in that discussion, and it is "archived", so I guess the issue is not resolved, and commenting further is not bad...
However, there is no conclusion in that discussion, and it is "archived", so I guess the issue is not resolved, and commenting further is not bad...
- Mon May 18, 2015 9:07 am
- Forum: [3.x] Discussion
- Topic: Replacing blocks of template code
- Replies: 2
- Views: 4488
Replacing blocks of template code
When writing extensions, it is often common to have the need to replace a block of HTML code in a template, for a number of reasons. With the current EVENT mechanism, you can ADD code in the specific places where this is anticipated, but you cannot remove or change existing code. As we extension dev...
- Sat Feb 04, 2012 7:43 pm
- Forum: [3.x][Archive] RFCs
- Topic: [RFC|Accepted] Updated BBcode engine
- Replies: 146
- Views: 245566
Re: [RFC|Accepted] Updated BBcode engine
Still I'd prefer an even 3rd proposal. Save local urls as partial urls. Yes, precisely what I meant: having the phpbb system to automatically detect these local URLs and have them stored as relative URLs in the posting text; this would automatically solve the issue So, how does this process progres...
- Thu Dec 22, 2011 10:17 am
- Forum: [3.x][Archive] RFCs
- Topic: [RFC|Accepted] Updated BBcode engine
- Replies: 146
- Views: 245566
Re: [RFC|Accepted] Updated BBcode engine
Hello, A somehow related issue that might be covered in this RFC as well is the treatment of "local" vs "external" URLs. In the current system, all URLs are stored complete, with protocol and domain. However, in the event of a migration to a different domain, or creation of a cop...