Search found 188 matches

by Marc
Mon Aug 11, 2014 5:49 am
Forum: [3.x][Archive] RFCs
Topic: Resize avatars and/or images on the client and server side
Replies: 7
Views: 21818

Resize avatars and/or images on the client and server side

There has already been some discussion on resizing avatars on this forum prior to this PR. Actually, a ticket for this already exists on the tracker: https://tracker.phpbb.com/browse/PHPBB3-11207 What I'm proposing here is that in addition to the suggested changes in this ticket, we should already t...
by Marc
Tue Jun 17, 2014 8:36 am
Forum: [3.1/Ascraeus] Merged RFCs
Topic: Drop support for Firebird
Replies: 12
Views: 97285

Re: Drop support for Firebird

+1
by Marc
Fri Jun 06, 2014 10:07 am
Forum: [3.x] Discussion
Topic: Ajax phpBB installation
Replies: 4
Views: 5954

Re: Ajax phpBB installation

It's really not worth the trouble for something you use once in a while.
by Marc
Thu May 29, 2014 2:42 pm
Forum: [3.x] Discussion
Topic: What Happened To The Report And Quote Buttons?
Replies: 60
Views: 80131

Re: What Happened To The Report And Quote Buttons?

I'm also not sure why the icons are being hidden. It doesn't make it look much cleaner and will just cause confusion among users.
by Marc
Sun May 11, 2014 8:29 am
Forum: [3.x] Discussion
Topic: Avoid/forbid "Click here" links
Replies: 12
Views: 12390

Re: Avoid/forbid "Click here" links

I think you should know that having things start two or three times with Install or Uninstall is a lot easier to distinguish than having everything start with "Click here". And yes, we should definitely make sure we're not making things harder for the blind by insisting on keeping such a b...
by Marc
Fri Apr 11, 2014 11:02 pm
Forum: [3.x][Archive] RFCs
Topic: [RFC] AJAX Quick Edit
Replies: 75
Views: 185183

Re: [RFC] AJAX Quick Edit

The current WIP quickedit does behave that way. ;)
Clicking on the edit button a second time actually opens up the full editor, too.
This is triggered by jQuery code that is returned with the AJAX request so an accidental double-click shouldn't cause one to accidentally go to the full editor. :)
by Marc
Fri Apr 11, 2014 8:58 pm
Forum: [3.x][Archive] RFCs
Topic: [RFC] AJAX Quick Edit
Replies: 75
Views: 185183

Re: [RFC] AJAX Quick Edit

I have created a ticket for this: https://tracker.phpbb.com/browse/PHPBB3-12393

edit: I have also created a WIP PR for this:
https://github.com/phpbb/phpbb/pull/2295
by Marc
Mon Jan 13, 2014 10:00 pm
Forum: [3.x][Archive] RFCs
Topic: Stop disabling super globals
Replies: 33
Views: 106242

Re: Stop disabling super globals

You have to use the global variable $request or pass the request class to your service container. It obviously won't work otherwise.
by Marc
Mon Jan 13, 2014 9:40 pm
Forum: [3.x][Archive] RFCs
Topic: Stop disabling super globals
Replies: 33
Views: 106242

Re: Stop disabling super globals

Maybe use $request->server('REMOTE_ADDR')?
by Marc
Mon Jan 13, 2014 9:20 pm
Forum: [3.x][Archive] RFCs
Topic: Stop disabling super globals
Replies: 33
Views: 106242

Re: Stop disabling super globals

Please don't use globals like $_POST in 3.1. There are methods like $request->is_set() and $request->is_set_post().