Search found 52 matches

by dmaj007
Sat Jan 29, 2005 12:50 am
Forum: [3.0/Olympus] Discussion
Topic: Yet another question on template::alter_block_array
Replies: 19
Views: 9413

Re: Yet another question on template::alter_block_array

*notes _tpl_load does not global $phpbb_root_path as it should, wonders why $template_names is still in set_filenames, whistles as he sees $trim_check_block not being used in compile.*
by dmaj007
Sat Jan 29, 2005 12:32 am
Forum: [3.0/Olympus] Discussion
Topic: Acyd's Antics, an inconsistency in the code
Replies: 23
Views: 12780

Re: Acyd's Antics, an inconsistency in the code

Sometimes i wonder if there is a bug where all posts from the development group gets hidden to all others[.] If there is, then it only affects dmaj007 as I saw your explanation the first time. Good for you. I guess you think I like causing trouble. Yup, I purposly did not read Acyd's post... Are yo...
by dmaj007
Fri Jan 28, 2005 9:13 pm
Forum: [3.0/Olympus] Discussion
Topic: Acyd's Antics, an inconsistency in the code
Replies: 23
Views: 12780

Re: Acyd's Antics, an inconsistency in the code

He doesn't list the changes... he was probably just going through the code, spotted it, and changed it for reasons of consistency. When it was checked-in, then the CVS diff-er-thingy-ma-bob notices this and produces the email. *cough*http://cvs.sourceforge.net/viewcvs.py/phpbb/phpBB2/includes/templ...
by dmaj007
Fri Jan 28, 2005 6:22 pm
Forum: [3.0/Olympus] Discussion
Topic: Acyd's Antics, an inconsistency in the code
Replies: 23
Views: 12780

Re: Acyd's Antics, an inconsistency in the code

Ah, nothing like make a good 'ol assumption out of thin air eh? I fear that you are not in a position to answer for Acyd, which would simply be unfair unless you are his publicist. He lists the change in the cvs changelogs, thus they must be significant to him in one way or another. I wish to unders...
by dmaj007
Fri Jan 28, 2005 4:05 pm
Forum: [3.0/Olympus] Discussion
Topic: Acyd's Antics, an inconsistency in the code
Replies: 23
Views: 12780

Re: Acyd's Antics, an inconsistency in the code

Ah, now it all makes much more sence... I thought you guys were gonna just start improving transactions or something of the like... Well, you did with mysqli... Anyway, whats up with count() being replaced with sizeof()? That one is still a mystery I cannot fathom from this end..
by dmaj007
Fri Jan 28, 2005 1:03 pm
Forum: [3.0/Olympus] Discussion
Topic: Yet another question on template::alter_block_array
Replies: 19
Views: 9413

Re: Yet another question on template::alter_block_array

Well I was never demanding anything, I apoligize if I was not able to make my stance on that bit of code clear. Oh well.. Now I just have to wait for bugtrack to open up..
by dmaj007
Fri Jan 28, 2005 1:02 pm
Forum: [3.0/Olympus] Discussion
Topic: Acyd's Antics, an inconsistency in the code
Replies: 23
Views: 12780

Re: Acyd's Antics, an inconsistency in the code

Why? Because they won't be able to use mysqli? A user would not go thru the trouble of finding another host, switch DBs, reroute DNS. I say this because phpBB is intended to be a forum solution, it is not a complete website. Regardless, the mysql4 and mysql3 drivers were IDENTICAL before he brought ...
by dmaj007
Fri Jan 28, 2005 1:44 am
Forum: [3.0/Olympus] Discussion
Topic: Acyd's Antics, an inconsistency in the code
Replies: 23
Views: 12780

Re: Acyd's Antics, an inconsistency in the code

Pardon but there are no 'people', 99% of the time, a USER will be installing this on a hosted solution. Will the host say "Well, since you can't reap the benefits of such and such a function, I will upgrade the DB, which has other customer's data creating downtime and a chance of failure." In realit...
by dmaj007
Fri Jan 28, 2005 12:29 am
Forum: [3.0/Olympus] Discussion
Topic: Yet another question on template::alter_block_array
Replies: 19
Views: 9413

Re: Yet another question on template::alter_block_array

/me smilies to himself as he sees $str being removed :)
by dmaj007
Wed Jan 26, 2005 12:19 pm
Forum: [3.0/Olympus] Discussion
Topic: Yet another question on template::alter_block_array
Replies: 19
Views: 9413

Re: Yet another question on template::alter_block_array

Yes, you prolly hate people who are... A little nuts... I was just thinking of a posibility that $mode is not either change or insert, but that should never happen, I was simply thinking of moving the return true outside of the conditionals andright at the end, at the closing bracket. It really does...