Search found 169 matches

by Marc
Thu Dec 27, 2012 5:12 pm
Forum: [3.1/Ascraeus] Merged RFCs
Topic: [RFC|Accepted] Avatar improvements, Gravatar
Replies: 15
Views: 39348

Re: [RFC|Accepted] Avatar improvements, Gravatar

User visible changes with the new modular avatar system: The avatar settings will no longer display as a page full of available avatar settings. Currently you see all settings for all enabled avatars. With the new system you will first choose the avatar you want to use with a drop-down list. Afterw...
by Marc
Tue Dec 18, 2012 10:09 pm
Forum: [3.1/Ascraeus] Merged RFCs
Topic: Moving to namespaces
Replies: 17
Views: 23795

Re: Moving to namespaces

Generally a +1 from me.

Also a big -1 for 3.1
by Marc
Sat Dec 08, 2012 12:59 am
Forum: [3.x] Discussion
Topic: Unapproved post status
Replies: 9
Views: 6536

Re: Unapproved post status

A while back I added something like that to the tracker: http://tracker.phpbb.com/browse/PHPBB3-9837 I haven't had much enthusiasm to work on this; mostly because the posted implementation is kind of hackish and possibly causes issues as Oleg pointed out in the tracker. Also it'll need some changes ...
by Marc
Mon Nov 19, 2012 12:11 pm
Forum: [3.1/Ascraeus] Merged RFCs
Topic: [RFC|Accepted] Avatar improvements, Gravatar
Replies: 15
Views: 39348

Re: [RFC|Accepted] Avatar improvements, Gravatar

I'd like to note that I have opened a WIP pull request at github: https://github.com/phpbb/phpbb3/pull/1100
by Marc
Thu Nov 08, 2012 12:28 pm
Forum: [3.1/Ascraeus] Merged RFCs
Topic: [RFC|Merged] Breadcrumb microdata
Replies: 26
Views: 56162

Re: [RFC] Breadcrumb microdata

Looks good to me.

+1
by Marc
Tue Nov 06, 2012 10:54 am
Forum: [3.x] Rejected RFCs
Topic: [RFC|Rejected] <base>
Replies: 16
Views: 17941

Re: [RFC] <base>

I'd say at least -1 for phpBB 3.1.
by Marc
Tue Nov 06, 2012 10:53 am
Forum: [3.x] Discussion
Topic: Integrating automatic image resizing
Replies: 61
Views: 52663

Re: Integrating automatic image resizing

@Marc ... Personally, I don't like that code. There are parts that are too repeated. For example, the $() is executed excessively. There's no need to execute that function that many times. You could simplify the browser's work with very simple changes to that code. IMO, if you reduce the use of the...
by Marc
Sun Nov 04, 2012 10:08 pm
Forum: [3.x] Discussion
Topic: Integrating automatic image resizing
Replies: 61
Views: 52663

Re: Integrating automatic image resizing

Adding this would be as easy as adding this or a similar code and executing it in $(document).ready() : /** * Image resizer */ function resize_images() { var maxWidth = $('div.content').innerWidth() - 30; // resize the attached images $('img', 'dt.attach-image').each(function(i){ // check the width ...
by Marc
Sun Nov 04, 2012 9:22 pm
Forum: [3.x] Rejected RFCs
Topic: [RFC|Rejected] <base>
Replies: 16
Views: 17941

Re: [RFC] <base>

How would this impact on the use of append_sid() (not sure if it's still that in 3.1)?
by Marc
Wed Oct 24, 2012 7:39 pm
Forum: [3.1/Ascraeus] Merged RFCs
Topic: [RFC|Merged] Make ext/ directory
Replies: 18
Views: 18392

Re: [RFC] Make ext/ directory

+1 for the idea
DavidIQ wrote:Or the usual blank index.htm file.
+1