Search found 1063 matches

by callumacrae
Thu May 28, 2015 1:47 pm
Forum: General Development Discussion
Topic: JS linting
Replies: 12
Views: 9833

Re: JS linting

To run it on Travis or on the command line, yeah. They have plugins for most editors, though.
by callumacrae
Thu May 28, 2015 1:11 pm
Forum: [3.x] Style Development
Topic: Defining a New Default Theme
Replies: 47
Views: 38924

Re: Defining a New Default Theme

A minor thing really, but since we're on the topic of design/theme update, couldn't the phpBB logo be tweaked ever so slightly too to look a bit cleaner and inline with current trends? I believe dropping the shadows/highlights creates the cleaner look. When you glance at Hanakin's proposed style gu...
by callumacrae
Thu May 28, 2015 12:14 pm
Forum: General Development Discussion
Topic: JS linting
Replies: 12
Views: 9833

JS linting

The JavaScript going in phpBB is a bit of a mess and looks like it was written by 20 different people (which it was).

I'd suggest we use JSHint and possibly JSCS, or ESLint.
by callumacrae
Thu May 28, 2015 9:42 am
Forum: [3.x] Style Development
Topic: Which IE versions should we kill?
Replies: 98
Views: 101761

Re: Which IE versions should we kill?

Kill all I.E! It's been dragging its heels for way too long IMO. Not true at all—the IE team have been doing great things recently. They've become more transparent with development and they're taking and implementing suggestions , the most noticeable of which is that they've turned on automatic upd...
by callumacrae
Sat Feb 28, 2015 11:29 am
Forum: [3.x][Archive] RFCs
Topic: [RFC] Automated Updating
Replies: 31
Views: 30121

Re: Auto-Update

DarkBeing wrote:-1
Just look at Microsoft.
+1, look at literally anyone else doing it. Just because Microsoft got it wrong fifteen years ago doesn't make it a bad idea.
by callumacrae
Fri Dec 12, 2014 12:14 pm
Forum: [3.x] Discussion
Topic: Commit messages and CRLF
Replies: 7
Views: 3510

Re: Commit messages and CRLF

Actually it is done by the commit inspector IIRC. And for the OP, sorry I don't think it is possible. So I assume that no one in the development team uses Github's web interface for creating pull requests - I'll have to stick with the git client, right? Check out hub to create pull requests from th...
by callumacrae
Thu Dec 11, 2014 3:19 pm
Forum: [3.x] Discussion
Topic: Commit messages and CRLF
Replies: 7
Views: 3510

Re: Commit messages and CRLF

I'm pretty sure nobody has ever checked commit messages for the correct line endings
by callumacrae
Fri Nov 14, 2014 4:36 pm
Forum: [3.x] Discussion
Topic: [Define New Theme] 3. We need to use a pre-processor such as LESS or which ever is decided upon at least in development.
Replies: 26
Views: 13258

Re: [Define New Theme] 3. We need to use a pre-processor such as LESS or which ever is decided upon at least in developm

Then why this need to make LESS a requirement? I can do whatever needs to be done in CSS directly, without using LESS. The end result is the same. Now, with LESS required, I have to go to the source files even for the smallest tweak. This will not make me any more efficient, actually... LESS! Becau...
by callumacrae
Tue Nov 11, 2014 12:07 am
Forum: [3.x] Tickets Discussion
Topic: [RFC] Ability to @mention specific users in posts
Replies: 241
Views: 159140

Re: [RFC] Ability to @mention specific users in posts

more simply, the spaces are a problem: when does we stop to search for the username? Does we search for @Hi @Hi Oh @Hi Oh Great @Hi Oh Great Conflict or @Hi Oh Great Conflict with spaces ? And this board alone has 2498 usernames with spaces . That's 4% And 2 with even more problematic names . That'...
by callumacrae
Tue Oct 21, 2014 6:47 pm
Forum: Chit Chat
Topic: Is 3.1 being installed in phpbb.com site right now?
Replies: 17
Views: 16386

Re: Is 3.1 being installed in phpbb.com site right now?

Alien_Time wrote:Refreshing to see these changes..
You shouldn't need to do that, now—it should be loading first time.