Search found 807 matches

by Arty
Wed Oct 14, 2015 7:58 am
Forum: [3.x] Discussion
Topic: [Define New Theme] 8. Utilize Font Awesome icons where icons are needed to simplify server requests.
Replies: 119
Views: 170177

Re: [Define New Theme] 8. Utilize Font Awesome icons where icons are needed to simplify server requests.

No, you got that wrong. Issue is latest post icon (red icon on left of topic title) is moved to its own line. Pagination is fine.
by Arty
Sun Oct 11, 2015 1:33 pm
Forum: [3.x] Discussion
Topic: [Define New Theme] 8. Utilize Font Awesome icons where icons are needed to simplify server requests.
Replies: 119
Views: 170177

Re: [Define New Theme] 8. Utilize Font Awesome icons where icons are needed to simplify server requests.

not actually an issue caused by anything in 3.2 it is there in 3.1 and is caused by horrible design/layout of prosilver so its not going to be a very clean fix, but ill look into it. No, its not in 3.1 and it is caused by changes in 3.2. More specifically by addition of display:inline-block to all ...
by Arty
Sat Oct 10, 2015 9:06 am
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-14227 - Trim topic titles so it wont messup the layout
Replies: 23
Views: 34364

Re: PHPBB3-14227 - Trim topic titles so it wont messup the layout

It is caused by using display:inline-block instead of display:inline on topic title: viewtopic.php?p=284116#p284116

Trimming is not a solution. Fixing display mode is.
by Arty
Mon Oct 05, 2015 2:30 pm
Forum: [3.x] Discussion
Topic: Feature freeze events in templates
Replies: 9
Views: 16659

Re: Feature freeze events in templates

However I'm still quite unsure how that would look like in practice (for example, what if the style uses different HTML then what the ext. author expects etc). In practice there are few issues I can think of: In phpBB templates are quite large, so searching for code might be more complex than neede...
by Arty
Mon Oct 05, 2015 2:18 pm
Forum: [3.x] Rejected RFCs
Topic: [Rejected] Removal of subsilver2 in 3.1
Replies: 75
Views: 118301

Re: [Rejected] Removal of subsilver2 in 3.1

Next thing you are going to ask how to make it work in Netscape 3? Nobody can help you with that because no sane person would waste time (first finding ancient computer with that browser, then banging head against the wall trying to make logical things work in ancient browser that doesn't understand...
by Arty
Mon Oct 05, 2015 2:10 pm
Forum: [3.x] Discussion
Topic: [Define New Theme] 8. Utilize Font Awesome icons where icons are needed to simplify server requests.
Replies: 119
Views: 170177

Re: [Define New Theme] 8. Utilize Font Awesome icons where icons are needed to simplify server requests.

It is caused by addition of this line: https://github.com/phpbb/phpbb/blob/master/phpBB/styles/prosilver/theme/links.css#L11 Browsers wrap inline and inline-block elements differently. When there are 2 inline elements in a row and whole text doesn't fit available width, browsers display split text l...
by Arty
Sun Oct 04, 2015 2:03 pm
Forum: [3.x] Discussion
Topic: Feature freeze events in templates
Replies: 9
Views: 16659

Re: Feature freeze events in templates

I think the main drawback of this would be that extensions could become incompatible with each other. Why? Replacing code doesn't mean old code is removed. So, for example, if some extension wants to append code after <!-- end of header -->, it should include search in replacement, allowing other e...
by Arty
Sun Oct 04, 2015 8:42 am
Forum: [3.x] Discussion
Topic: Feature freeze events in templates
Replies: 9
Views: 16659

Re: Feature freeze events in templates

What do you mean by template modifications? See https://area51.phpbb.com/phpBB/viewtopic.php?t=43453&start=80 (second part of post and there is discussion on previous page of that thread) Its an idea implemented in vBulletin many years ago as third party add-on that quickly became very popular amon...
by Arty
Sun Oct 04, 2015 8:32 am
Forum: [3.x] Discussion
Topic: Feature freeze events in templates
Replies: 9
Views: 16659

Re: Feature freeze events in templates

Good point. With current template events system someone will get screwed - ether style devs or extension devs. Ideally whole system should be replaced with template modifications. It is way more powerful and flexible than template events and would make both style and extension developers happy. Howe...
by Arty
Sat Oct 03, 2015 3:19 pm
Forum: [3.x] Discussion
Topic: Feature freeze events in templates
Replies: 9
Views: 16659

Feature freeze events in templates

I suggest to include template events to feature freeze for 3.2, so minor updates, like 3.2.1, wouldn't add new template events. Currently in 3.1 styles require updates for every minor release because of array of events that are added to templates. That means authors have to release updates every few...