Search found 793 matches

by Arty
Mon Oct 05, 2015 2:18 pm
Forum: [3.x] Rejected RFCs
Topic: [Rejected] Removal of subsilver2 in 3.1
Replies: 75
Views: 89307

Re: [Rejected] Removal of subsilver2 in 3.1

Next thing you are going to ask how to make it work in Netscape 3? Nobody can help you with that because no sane person would waste time (first finding ancient computer with that browser, then banging head against the wall trying to make logical things work in ancient browser that doesn't understand...
by Arty
Mon Oct 05, 2015 2:10 pm
Forum: [3.x] Discussion
Topic: [Define New Theme] 8. Utilize Font Awesome icons where icons are needed to simplify server requests.
Replies: 119
Views: 136331

Re: [Define New Theme] 8. Utilize Font Awesome icons where icons are needed to simplify server requests.

It is caused by addition of this line: https://github.com/phpbb/phpbb/blob/master/phpBB/styles/prosilver/theme/links.css#L11 Browsers wrap inline and inline-block elements differently. When there are 2 inline elements in a row and whole text doesn't fit available width, browsers display split text l...
by Arty
Sun Oct 04, 2015 2:03 pm
Forum: [3.x] Discussion
Topic: Feature freeze events in templates
Replies: 9
Views: 15300

Re: Feature freeze events in templates

I think the main drawback of this would be that extensions could become incompatible with each other. Why? Replacing code doesn't mean old code is removed. So, for example, if some extension wants to append code after <!-- end of header -->, it should include search in replacement, allowing other e...
by Arty
Sun Oct 04, 2015 8:42 am
Forum: [3.x] Discussion
Topic: Feature freeze events in templates
Replies: 9
Views: 15300

Re: Feature freeze events in templates

What do you mean by template modifications? See https://area51.phpbb.com/phpBB/viewtopic.php?t=43453&start=80 (second part of post and there is discussion on previous page of that thread) Its an idea implemented in vBulletin many years ago as third party add-on that quickly became very popular amon...
by Arty
Sun Oct 04, 2015 8:32 am
Forum: [3.x] Discussion
Topic: Feature freeze events in templates
Replies: 9
Views: 15300

Re: Feature freeze events in templates

Good point. With current template events system someone will get screwed - ether style devs or extension devs. Ideally whole system should be replaced with template modifications. It is way more powerful and flexible than template events and would make both style and extension developers happy. Howe...
by Arty
Sat Oct 03, 2015 3:19 pm
Forum: [3.x] Discussion
Topic: Feature freeze events in templates
Replies: 9
Views: 15300

Feature freeze events in templates

I suggest to include template events to feature freeze for 3.2, so minor updates, like 3.2.1, wouldn't add new template events. Currently in 3.1 styles require updates for every minor release because of array of events that are added to templates. That means authors have to release updates every few...
by Arty
Sun Nov 30, 2014 10:31 pm
Forum: [3.x][Archive] RFCs
Topic: Template engine changes to allow for structure flexibility
Replies: 40
Views: 42625

Re: Template engine changes to allow for structure flexibility

PayBas wrote:But that will also create some confusion, as it will probably double the number of template files.
Only in parent style: prosilver. Third party styles will only modify old templates like overall_header.html
by Arty
Wed Nov 19, 2014 6:39 pm
Forum: [3.x][Archive] RFCs
Topic: Template engine changes to allow for structure flexibility
Replies: 40
Views: 42625

Re: Template engine changes to allow for structure flexibility

The enhancements to inheritance are demonstrated in https://gist.github.com/michaelcullum/68f8f95bcb4676ea2563 - this means it allows usage of more than one parent (instead we are moving more to a standard dependencies model where you could even have two styles requiring each other) and explicit de...
by Arty
Wed Nov 19, 2014 12:26 pm
Forum: [3.x][Archive] RFCs
Topic: Template engine changes to allow for structure flexibility
Replies: 40
Views: 42625

Re: Template engine changes to allow for structure flexibility

And why that can't be done with simple renaming? Why do you need to add extra bloat?
by Arty
Wed Nov 19, 2014 9:15 am
Forum: [3.x][Archive] RFCs
Topic: Template engine changes to allow for structure flexibility
Replies: 40
Views: 42625

Re: Template engine changes to allow for structure flexibility

And how does mapping help you with that? It is still a simple rename. You can break it into object with current naming or after mapping - it won't make any difference.