Search found 1063 matches

by imkingdavid
Tue Nov 12, 2013 2:26 pm
Forum: [3.x][Archive] RFCs
Topic: Prevent multiple inclusions of jQuery UI
Replies: 37
Views: 22775

Re: Prevent multiple inclusions of jQuery UI

jQuery UI is a lot more expensive to do that. If it's expensive then it shouldn't be added just because it might be used. It's not "might be used". I'm already using it in one of my extensions. IMO, we should just add a manifest-like option to extension authors that allows them to request libraries...
by imkingdavid
Mon Nov 11, 2013 7:11 pm
Forum: [3.x][Archive] RFCs
Topic: Prevent multiple inclusions of jQuery UI
Replies: 37
Views: 22775

Prevent multiple inclusions of jQuery UI

If jQuery UI is included multiple times into a page, it can stop working or else work incorrectly. We need to prevent multiple inclusions of the jQuery UI library so that such issues don't come up. The problem is, many extensions will likely need to use jQuery UI. One proposed solution was <script>w...
by imkingdavid
Mon Nov 11, 2013 3:36 pm
Forum: [3.1/Ascraeus] Merged RFCs
Topic: Rename "purge" to "uninstall", differentiate between "install" and "enable"
Replies: 23
Views: 13707

Re: Rename "purge" to "uninstall", differentiate between "install" and "enable"

Could we add a 0-default "extension_id" field to the modules table that could be used to associate extensions with their added modules? It would be assigned in the background when the module.add migration is run, and then it would be a simple action during the disable process to grab all of the exte...
by imkingdavid
Sat Nov 09, 2013 5:45 am
Forum: [3.x] Discussion
Topic: Event requests checked by QA teams
Replies: 4
Views: 2892

Re: Event requests checked by QA teams

Development team members review every pull request and decide whether or not to merge them. Anyone may discuss in the PR. I don't see a need to make any changes.
by imkingdavid
Sat Nov 09, 2013 5:41 am
Forum: General Development Discussion
Topic: Adding template events, what do I fork?
Replies: 2
Views: 3277

Re: Adding template events, what do I fork?

To add to that, please be sure to follow our commit message guidelines when committing your changes. Also, be sure to base your branch on the "develop" branch. Oh, and don't forget to add the event to phpBB/docs/events.md in alphabetical order, following the existing formatting.
by imkingdavid
Fri Nov 08, 2013 11:36 pm
Forum: [3.x] Discussion
Topic: phpBB 3.1 Information and Status
Replies: 187
Views: 137653

Re: phpBB 3.1 Information and Status

Extensions cannot modify core files, by definition. If you need an event in a specific location in core code the only way to add it is via a pull request to the repository.
by imkingdavid
Tue Nov 05, 2013 3:39 am
Forum: [3.1/Ascraeus] Merged RFCs
Topic: Rename "purge" to "uninstall", differentiate between "install" and "enable"
Replies: 23
Views: 13707

Re: Rename "purge" to "uninstall", differentiate between "install" and "enable"

I'd argue that you are "turning on" an extension. While some extensions may simply be made active and require further set up before they start working, other extensions will be tools that just need to be told to start working. For instance, you might add an extension that keeps track of how many use...
by imkingdavid
Sat Nov 02, 2013 9:37 pm
Forum: [3.1/Ascraeus] Merged RFCs
Topic: Rename "purge" to "uninstall", differentiate between "install" and "enable"
Replies: 23
Views: 13707

Re: Rename "purge" to "uninstall", differentiate between "install" and "enable"

We had a discussion on IRC ( view full discussion ) and came to the following conclusions: We will keep the current "enable" terminology without differentiating between install and enable. We will keep the current "disable" terminology. We will rename "purge" to "Delete Data", and this option will o...
by imkingdavid
Sat Nov 02, 2013 9:13 pm
Forum: [3.1/Ascraeus] Merged RFCs
Topic: Rename "purge" to "uninstall", differentiate between "install" and "enable"
Replies: 23
Views: 13707

Rename "purge" to "uninstall", differentiate between "install" and "enable"

Currently, on the extensions list page, there are three options available for extensions: enable - this can be done if an extension's migrations have not yet been run, or if was disabled after the migrations were run; it causes functionality to start working disable - this can be done if an extensio...
by imkingdavid
Sat Nov 02, 2013 12:38 am
Forum: [3.x] Discussion
Topic: Profiles in tabs
Replies: 10
Views: 5111

Re: Profiles in tabs

I'm not sure I'd want tabs. Seems like a lot of effort for users just wanting to see specific data. I'd rather focus on making the current page look better with a more user-friendly layout than break it all up across multiple tabs.