Search found 737 matches

by nickvergessen
Tue Feb 17, 2015 6:08 pm
Forum: General Development Discussion
Topic: Git development branches
Replies: 23
Views: 18989

Re: Git development branches

Just tested on my newspage extension, and outstanding PRs are closed, without an option to be reopened. https://github.com/nickvergessen/phpbb-ext-newspage/pull/109 So I'd say we create the new branches, new stuff goes against 3.y.x branches, and we merge stuff into them. Once the majority of the cu...
by nickvergessen
Tue Feb 17, 2015 5:53 pm
Forum: [3.x][Archive] RFCs
Topic: remove childish Reset button
Replies: 5
Views: 4301

Re: remove childish Reset button

I agree, that these kind of buttons are not used a lot anymore, so I tend to agree
by nickvergessen
Tue Feb 17, 2015 5:52 pm
Forum: General Development Discussion
Topic: Git development branches
Replies: 23
Views: 18989

Re: Git development branches

Does anyone know what happens to PRs against a branch that is deleted on github?
I mean we can merge them just right, but I guess the UI breaks?
by nickvergessen
Mon Feb 16, 2015 10:39 pm
Forum: [3.x] Event Requests
Topic: [PHP] core.ucp_pm_compose_predefined_message
Replies: 4
Views: 5529

Re: [PHP] core.ucp_pm_compose_predefined_message

Well we don't need $message_text = $message_subject = ''; $vars = array( 'message_text', 'message_subject', ); extract($phpbb_dispatcher->trigger_event('core.ucp_pm_compose_predefined_message', compact($vars))); But the code you want to run there, so we can see whether it actually makes sense like t...
by nickvergessen
Mon Feb 16, 2015 10:36 pm
Forum: [3.2/Rhea] Merged RFCs
Topic: [RFC] Integrate s9e\TextFormatter
Replies: 168
Views: 100747

Re: [RFC] Integrate s9e\TextFormatter

Well adding a url field to the author on quotes is only half the feature we had before. Previously you could also color it (e.g. with the administrator color on admin posts) sample With all these BC breaks, I personally would not like to have it changed. However I can also see the PR growing infinit...
by nickvergessen
Sun Feb 15, 2015 8:12 pm
Forum: [3.x] Event Requests
Topic: [PHP] core.ucp_pm_compose_predefined_message
Replies: 4
Views: 5529

Re: [PHP] core.ucp_pm_compose_predefined_message

Can you please (for all of your requests) state what you want to do, and maybe post some example code?
Your given explanations are not very helpful to see what you want to do, so we can't tell you whether you can use another already existing event for that.
by nickvergessen
Sat Feb 14, 2015 11:13 pm
Forum: General Development Discussion
Topic: Git development branches
Replies: 23
Views: 18989

Re: Git development branches

My only concern is for the extensions that clone the develop-ascraeus branch for phpunit testing. They will have their testing platform disrupted by this change, until obviously they update to use the new 3.1.x branch. Well we can keep the old develop-* branches around for quite sometime, until stu...
by nickvergessen
Sat Feb 14, 2015 11:04 pm
Forum: General Development Discussion
Topic: Git development branches
Replies: 23
Views: 18989

Re: Git development branches

+1, we had quite some questions "which branch is 3.1" latly on github
by nickvergessen
Fri Feb 13, 2015 8:22 pm
Forum: [3.x] Discussion
Topic: phpBB Arcade mod convert ext - phpBB 3.1 missing event
Replies: 9
Views: 6504

Re: phpBB Arcade mod convert ext - phpBB 3.1 missing event

Just edit the first post, but also note that most of your events are already available, just at a little different place, but they allow the same modification.

As for the faq sample, I think you should just copy the code and use a controller.
We are doing that for phpBB itself aswell in 3.2
by nickvergessen
Thu Feb 12, 2015 1:36 pm
Forum: [3.x][Archive] RFCs
Topic: new topic lock option...
Replies: 14
Views: 17650

Re: new topic lock option...

neuropass wrote:one of those wtf moment. why was this never implemented I have no clue. definitely part of the core not an extension.
Well the RFC forums are currently unusable because they are used for many different things at the same time.
I created a ticket for it: https://tracker.phpbb.com/browse/PHPBB3-13598