Search found 50 matches

by Jhong
Wed Sep 01, 2010 1:46 am
Forum: [3.x] Discussion
Topic: Please improve function and global var namespacing
Replies: 13
Views: 11364

Re: Please improve function and global var namespacing

Yes, if we could get the low-hanging fruit, that would be great --- just renaming make_clickable and validate_username for now would solve the immediate problem with WordPress. Even if in the future we use PHP 5.3 namespaces (in all their weird backslash glory), I assume it is only going to help if ...
by Jhong
Tue Aug 31, 2010 1:48 pm
Forum: [3.x] Discussion
Topic: Please improve function and global var namespacing
Replies: 13
Views: 11364

Re: Please improve function and global var namespacing

I agree -- yes, it is all packages' job to namespace properly.

How about this: a compatibility layer that is off by default?

The compatibility layer need only be an include file that passes old functions to new ones, and creates references to global variables using the old names.
by Jhong
Tue Aug 31, 2010 7:54 am
Forum: [3.x] Discussion
Topic: Plugins / Hooks Section in ACP
Replies: 3
Views: 4373

Re: Plugins / Hooks Section in ACP

Should this be something end-user-controllable? Shouldn't it be down to mod authors to understand and control the priority of their code in the hook call hierarchy? Imagine how difficult it would be writing a MOD if the user was allowed to control how individual functions would be executed --- night...
by Jhong
Tue Aug 31, 2010 7:38 am
Forum: [3.x] Discussion
Topic: Please improve function and global var namespacing
Replies: 13
Views: 11364

Please improve function and global var namespacing

I understand that 3.1 will be much more OOP, but I still think this is worth mentioning. One of my long-term bug-bears with phpBB has been poor function and global variable naming. Makes my life very difficult: Right now, these functions cause me trouble: validate_username make_clickable These globa...
by Jhong
Tue Aug 31, 2010 7:15 am
Forum: [3.1/Ascraeus] Merged RFCs
Topic: [RFC|Merged] Include and use jQuery (originally for 3.2)
Replies: 74
Views: 57354

Re: [RFC] Include and use jQuery

Yes to including jQuery :-) No to loading from Google (or another CDN). While google's servers may be reliable, my connection to them is not. Particularly here in China, various Google services are often arbitrarily blocked. All JS should be served from the phpBB instance itself. The loading needs t...
by Jhong
Tue Aug 31, 2010 5:51 am
Forum: [3.x] Discussion
Topic: Translations -- use GNU GetText please
Replies: 29
Views: 25305

Translations -- use GNU GetText please

I did a search and didn't find anything recent relating to the phpBB translation process. As a mod author, I find the translation system really grating: - I have to keep track of constants across multiple files. - As translations go out of date, the templates fall back to showing constants rather th...
by Jhong
Thu Aug 26, 2010 5:40 am
Forum: [3.x] Discussion
Topic: Remove duplicate css of stylesheet files
Replies: 8
Views: 14574

Re: Remove duplicate css of stylesheet files

Yes, the +1 was in response to rahber's comment. Digging through multiple CSS files is a pain. If Firebug won't work, CSS Tidy might do the trick: http://csstidy.sourceforge.net/ I also wrote a CSS parser class ("CSS magic") for WP-United that parses CSS, performs operations (modifies selector speci...
by Jhong
Thu Aug 26, 2010 4:12 am
Forum: [3.x] Discussion
Topic: Change "less than a minute ago" to something shorter
Replies: 16
Views: 16201

Re: Change "less than a minute ago" to something shorter

I like "Just now" -- very informal. It can always be edited in the language file anyway.
by Jhong
Thu Aug 26, 2010 4:10 am
Forum: [3.x] Discussion
Topic: Remove duplicate css of stylesheet files
Replies: 8
Views: 14574

Re: Remove duplicate css of stylesheet files

firebug should be good enough -- it can show you the resultant CSS for the page.

A big +1 for combining the CSS into a single file (with a separate file for IE-specific hacks). It will make mods and administration much easier.
by Jhong
Wed Aug 25, 2010 4:38 am
Forum: [3.x] Discussion
Topic: Official Bridges
Replies: 11
Views: 8347

Re: Official Bridges

Bridges could never be included in the core, or even look anything like included -- it would mean that phpBB would have to release an update whenever a bridged application broke compatibility, which would be ridiculously onerous. I think the improved hooks system will make bridge compatibility much ...