Search found 291 matches

by ToonArmy
Thu Sep 02, 2010 6:33 am
Forum: [3.x] Discussion
Topic: Login after register
Replies: 23
Views: 36234

Re: Login after register

Maybe an option saying 'Would you like to Auto-Login After Registration'? Suggest not to over-complicate this -- if it ends up in displaying more options to the user, or stuffing the ACP with even more options, it doesn't provide much benefit. I think sensible defaults make more sense than trying t...
by ToonArmy
Thu Sep 02, 2010 6:32 am
Forum: [3.x] Discussion
Topic: [Usability] Reducement of confirmation pages / Allow undo
Replies: 37
Views: 39301

Re: [Usability] Reducement of confirmation pages / Allow und

We need to reduce the number of confirm boxes, however they cannot go entirely because of CSRF. See http://blog.phpbb.com/2009/01/14/fighting-csrf/ In addition there are also things which are irrecoverable and thus the user needs to be sure. Link hashes for GET requests and Form tokens for POST req...
by ToonArmy
Wed Sep 01, 2010 8:23 pm
Forum: [3.x] Discussion
Topic: Wave Federation Protocol Integration (API)
Replies: 29
Views: 27300

Re: Wave Federation Protocol Integration (API)

GravityDK wrote:Wave is being shut down by Google.
I recommend its removed from the Use Cases on Wiki.
Wave was just a product built on top of the protocols Google have released, it doesn't need Wave to work. It's quite an interesting idea and there isn't any harm in it being on the wiki.
by ToonArmy
Wed Sep 01, 2010 4:14 pm
Forum: [3.x] Discussion
Topic: [Usability] Reducement of confirmation pages / Allow undo
Replies: 37
Views: 39301

Re: [Usability] Reducement of confirmation pages / Allow und

We need to reduce the number of confirm boxes, however they cannot go entirely because of CSRF. See http://blog.phpbb.com/2009/01/14/fighting-csrf/ In addition there are also things which are irrecoverable and thus the user needs to be sure.
by ToonArmy
Tue Aug 31, 2010 11:15 pm
Forum: [3.x] Discussion
Topic: Please improve function and global var namespacing
Replies: 13
Views: 16345

Re: Please improve function and global var namespacing

4.x should be namespaced properly, there shouldn't be any global variables like $user used, and everything should have unique non-conflicting names (prefixed with phpbb_). 4.x actually requires PHP 5.3 which has namespacing support, thus classes and function do _not_ have to be prefixed with phpbb_...
by ToonArmy
Tue Aug 31, 2010 12:53 pm
Forum: [3.x] Discussion
Topic: Please improve function and global var namespacing
Replies: 13
Views: 16345

Re: Please improve function and global var namespacing

make_clickable -> make_forumpost_clickable validate_username -> validate_phpbb_username Prefix the functions with 'phpbb_' rather than renaming them to something that again may conflict with something else. In my case, it is WordPress. Yes, WordPress is to blame too, but since they have a mature pl...
by ToonArmy
Sat Aug 28, 2010 4:17 pm
Forum: General Development Discussion
Topic: Git hooks
Replies: 53
Views: 67943

Re: Git hooks

nn- wrote:wc -l is specified in posix (http://www.opengroup.org/onlinepubs/000 ... es/wc.html), use it instead of --lines.

Max line length sounds like it could be replaced with cut.
How would one go about that with cut?
by ToonArmy
Fri Aug 20, 2010 2:59 pm
Forum: [3.1/Ascraeus] Merged RFCs
Topic: [RFC|Merged] Modular cron
Replies: 93
Views: 104254

Re: [RFC|Accepted] Modular cron

Really liking the look of this, few things I've noticed:
  • Some class methods don't have a visibility defined.
  • A number of classes are included manually
  • The cron_task interface file has another interface in the file
by ToonArmy
Fri Aug 20, 2010 2:50 pm
Forum: [3.x] Discussion
Topic: AJAX Multiple File Upload
Replies: 10
Views: 13067

Re: Attachment Password & Multiple File Upload

Yes, uploading multiple files without having to reload the page (using AJAX or even just plain JS to add a new file input field) would greatly improve the user experience. For example when uploading a ton of photos. Further more that little page refresh is confusing for some users. To me it just a ...
by ToonArmy
Fri Aug 20, 2010 2:47 pm
Forum: General Development Discussion
Topic: Git hooks
Replies: 53
Views: 67943

Re: Git hooks

bantu wrote:
nn- wrote:Useful error message in pre-commit hook when php is not installed: http://github.com/p/phpbb3/compare/git-tools
Good idea. Created ticket http://tracker.phpbb.com/browse/PHPBB3-9777
FYI It's been merged and just needs verifying.