Search found 66 matches

by mrgoldy
Fri Nov 29, 2019 2:08 pm
Forum: [3.x] Discussion
Topic: Control panel module system
Replies: 33
Views: 54230

Re: Control panel module system

Control panel 'items' are now declared as service parameters. mcp.mcp_cat_main: route: 'mcp_index' mcp.mcp_index: parent: 'mcp_cat_main' route: path: /index defaults: _controller: mcp.front:main mcp.mcp_view_forum: auth: '(forum_id || topic_id || post_id) && acl_m_,forum_id' parent: 'mcp_cat_main' r...
by mrgoldy
Fri Nov 29, 2019 1:37 pm
Forum: [3.x] Discussion
Topic: Control panel module system
Replies: 33
Views: 54230

Re: Control panel module system

Okay, so the initial conversion is complete. With a stack of 5 dependent PR's, everything is moved and functioning. ACP Modules to controllers MCP Modules to controllers UCP Modules to controllers CP Services and items CP Common code and tests The Travis and AppVeyor tests are also passing. However,...
by mrgoldy
Mon Sep 09, 2019 6:30 pm
Forum: [3.x] Discussion
Topic: Read-only event variables
Replies: 6
Views: 8661

Re: Read-only event variables

I understand the identifiers. They should probably be static. However, for example forum_data or topic_data is sometimes altered by extensions. I know of extensions (among others some of my/our own) that add (add, not alter) data to an event variable that is available within multiple events in a fil...
by mrgoldy
Mon Sep 09, 2019 3:34 pm
Forum: [3.x] Discussion
Topic: Read-only event variables
Replies: 6
Views: 8661

Re: Read-only event variables

Could you provide an example that would create a lot of possible execution paths? And isn't the way of thinking supposed to be: The core code works and if an extension breaks it using an event, the extension is at fault. It should either handle the 'alternative execution path' itself or not alter it...
by mrgoldy
Wed Aug 28, 2019 8:12 pm
Forum: [3.x] Discussion
Topic: DocBlocks
Replies: 15
Views: 20596

Re: DocBlocks

Well, the thing is, it is even documented as such: https://docs.phpdoc.org/guides/docblocks.html
And most editors auto paste them like that, aswell as other repositories use this approach.
by mrgoldy
Wed Aug 28, 2019 6:23 pm
Forum: [3.x] Discussion
Topic: DocBlocks
Replies: 15
Views: 20596

DocBlocks

Lately I got a little irritated by docblocks throughout the code being rather inconsistent. And I was wondering what your thoughts on them are. With a final solution, I can start 'cleaning' them up if need be. Should asterixes be indented with a space? In my opinion: Yes /** * A docblock */ /** * A ...
by mrgoldy
Tue Aug 20, 2019 7:46 pm
Forum: [3.x] Discussion
Topic: phpBB 3.2.8-RC1 released
Replies: 9
Views: 9972

Re: phpBB 3.2.8-RC1 released

Where should I document those?
Or just write a small posts in the Ext Writers forum or something?
by mrgoldy
Mon May 20, 2019 9:55 am
Forum: [3.x] Discussion
Topic: Control panel module system
Replies: 33
Views: 54230

Re: Control panel module system

Well, seeing this is targeted for 4.0 that should be fine. I am currently coding against master branch and it's working as intended. One thing to note though, is that the order in which arguments are defined in .yml does not matter, however if you want to define the Xth (say 4) parameter in the clas...
by mrgoldy
Tue May 14, 2019 10:47 am
Forum: [3.x] Discussion
Topic: Control panel module system
Replies: 33
Views: 54230

Re: Control panel module system

I quickly spoke with nicofuma, and he says it looks nice. He also brought up a good point about the arguments, as symfony allows "named arguments". This means prefixing them with $ . acp_general: tags: { name: acp } class: \phpbb\cp\item shared: false arguments: $auth: acl_a $icon: cogs $route: acp_...
by mrgoldy
Mon May 13, 2019 8:45 pm
Forum: [3.x] Discussion
Topic: Control panel module system
Replies: 33
Views: 54230

Re: Control panel module system

Okay, so I saw a new light :bulb: This way the amount of 'declarations' is minimized. We will have to create all '*cp routes' ourselves and not through a routing.yml file. Which should be better anyways, so we define the prefix (eg, '/admin', '/moderator', '/user'). We will have service declaration ...