Search found 29 matches

by posey
Mon Feb 25, 2019 2:32 pm
Forum: [3.x] Discussion
Topic: Control panel module system
Replies: 26
Views: 14441

Re: Control panel module system

Bit stating the obvious here, but I think we can agree on the fact that we're all leaning towards the following structure: Each control panel page (module) will have its own route. Each control panel route will have its own controller. Each control panel will have its own navigation declared with se...
by posey
Sat Feb 23, 2019 10:47 pm
Forum: [3.x] Discussion
Topic: Control panel module system
Replies: 26
Views: 14441

Re: Control panel module system

Okay, let's post an update. There was a valid point made that with a yml approach, it might be possible to completely cache it. While the services are cached, the order is not. So that together with the fact it's rather hard to make a water-proof before/after ordered collection (not to mention with ...
by posey
Sat Feb 23, 2019 6:22 am
Forum: [3.x] Discussion
Topic: Control panel module system
Replies: 26
Views: 14441

Re: Control panel module system

And about the approach/thought proposed by CHItA. I've been looking into it and thinking about it some more. This would mean we would have to register each menu item in a yml file, and if it's a menu category, create a service collection for it aswell. Example: services: phpbb.acp.collection: class:...
by posey
Sat Feb 23, 2019 6:03 am
Forum: [3.x] Discussion
Topic: Control panel module system
Replies: 26
Views: 14441

Re: Control panel module system

Seeing I am an extension developer myself, I do take extensions into consideration. That being said, it's major code rework and a lot of the core files are going to chance, so somethings gotta give. However, as most of the extensions already use a admin_controller.php of sorts (and I know you're one...
by posey
Fri Feb 22, 2019 1:41 pm
Forum: [3.x] Discussion
Topic: Control panel module system
Replies: 26
Views: 14441

Re: Control panel module system

No it does not, nothing concrete is being discussed in that topic on how it should function. Also, as mentioned, do not look at the style in the codepen, that was me just playing around, just at the categories, subcategories and actual modes. Which I have also listed above, with their respective rou...
by posey
Fri Feb 22, 2019 10:39 am
Forum: [3.x] Discussion
Topic: Control panel module system
Replies: 26
Views: 14441

Re: Control panel module system

Okay, that sounds great and ideal for back end coding. Will drop the customisation options for an Administrator but as far as I can tell, that is never used. Perhaps it's now also a good time to talk about "reorganising" the menu a bit? As there are a lot of duplicate entries in the ACP and I think ...
by posey
Tue Feb 19, 2019 3:44 pm
Forum: [3.x] Discussion
Topic: Control panel module system
Replies: 26
Views: 14441

Control panel module system

So, let's talk modules. I know it's listed as a GSoC idea. This is just to talk about how it should look / what approach to take, regardless of whom the developer might be. I've been looking into the module system lately and there are quite a few problems, of which most are already known but let's l...
by posey
Mon Dec 10, 2018 4:45 pm
Forum: [3.x] Discussion
Topic: Twig extensions
Replies: 6
Views: 4498

Re: Twig extensions

I have created the related PR (https://github.com/phpbb/phpbb/pull/5480)
Unfortunately {{ auth() }} doesn't seem to be on the table at the moment, atleast not with my knowledge.
Feel free to suggest more functions, filters and tags.
Perhaps something like a switch() {} template tag..
by posey
Sun Dec 09, 2018 1:36 pm
Forum: General Development Discussion
Topic: Moving developement discussion to Discord
Replies: 47
Views: 38642

Re: Moving developement discussion to Discord

And mine is mrgoldy #5760
by posey
Thu Dec 06, 2018 7:36 pm
Forum: General Development Discussion
Topic: Renderer class - why these two variables are different
Replies: 5
Views: 3942

Re: Renderer class - why these two variables are different

Yes it does, it made that specific renderer available in the events.