Search found 72 matches

by P_I
Mon Mar 13, 2017 3:32 pm
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-15086 Replace quote.gif with fontawesome icon
Replies: 13
Views: 16820

Re: PHPBB3-15086 Replace quote.gif with fontawesome icon

any/everyone is responsible for the changes... best way I have found to test them is in your browser change the class on the body from ltr to rtl, then on the html element change the dir to rtl as well. you will have to manually add the bidi.css file to your header... Otherwise if you can then inst...
by P_I
Mon Mar 13, 2017 4:24 am
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-15086 Replace quote.gif with fontawesome icon
Replies: 13
Views: 16820

Re: PHPBB3-15086 Replace quote.gif with fontawesome icon

I sure have learned a lot from this initial effort to contribute to phpBB and the comments/reviews that I've been given on the pull request have been very educational. Thanks to hanakin and vinny for sharing their knowledge, it has been much appreciated. However, as a newcomer, I've struggled to und...
by P_I
Wed Mar 08, 2017 1:20 pm
Forum: General Development Discussion
Topic: Restarting/repeating travis-ci build after random failure
Replies: 3
Views: 5519

Re: Restarting/repeating travis-ci build after random failure

Thanks to whomever restarted the build. As a new contributor to phpBB, bumping into problems like this can be a bit on the frustrating part, particularly when there doesn't seem to be any breadcrumbs/documentation that describes the likely causes and resolution steps AFAIK. I am trying to keep notes...
by P_I
Wed Mar 08, 2017 5:18 am
Forum: General Development Discussion
Topic: Restarting/repeating travis-ci build after random failure
Replies: 3
Views: 5519

Restarting/repeating travis-ci build after random failure

Please help the newbie understand how to restart/repeat a travis-ci build after an apparent random failure. After looking at my recent commit build which failed, I don't think the error is related to my code change. I seem to be 2 for 2 on having this problem , so I'd like to understand what is the ...
by P_I
Wed Mar 08, 2017 3:33 am
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-15086 Replace quote.gif with fontawesome icon
Replies: 13
Views: 16820

Re: PHPBB3-15086 Replace quote.gif with fontawesome icon

any/everyone is responsible for the changes... best way I have found to test them is in your browser change the class on the body from ltr to rtl, then on the html element change the dir to rtl as well. you will have to manually add the bidi.css file to your header... Thanks, that's very useful to ...
by P_I
Thu Feb 23, 2017 7:24 pm
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-15086 Replace quote.gif with fontawesome icon
Replies: 13
Views: 16820

Re: PHPBB3-15086 Replace quote.gif with fontawesome icon

hanakin wrote:
Thu Feb 23, 2017 6:44 pm
411 the new version of FA includes both quote-left and quote-right icons
Thanks. I caught that and used quote-right for RTL as it was already using quote_rtl.gif.
by P_I
Thu Feb 23, 2017 1:35 pm
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-15086 Replace quote.gif with fontawesome icon
Replies: 13
Views: 16820

Re: PHPBB3-15086 Replace quote.gif with fontawesome icon

I cannot find any guidelines on what to do with the RTL case. Are there coding guidelines for RTL in templates and/or CSS? As I try to come up to speed on contributing to the project, there remain a few mysteries. This is one of them. I think I've found the code in bidi.css and can follow the examp...
by P_I
Thu Feb 23, 2017 5:05 am
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-15086 Replace quote.gif with fontawesome icon
Replies: 13
Views: 16820

Re: PHPBB3-15086 Replace quote.gif with fontawesome icon

this is better handled via a base64 svg in the css than using font-awsome. but yes there are issues with the bbcode somewhere https://area51.phpbb.com/phpBB/viewtopic.php?f=126&t=50486 Thanks. Still haven't solved why bbcode.html isn't being used, but you've given me the necessary clues about using...
by P_I
Wed Feb 22, 2017 8:36 pm
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-15086 Replace quote.gif with fontawesome icon
Replies: 13
Views: 16820

PHPBB3-15086 Replace quote.gif with fontawesome icon

This one seemed simple to me. Change styles/prosilver/template/bbcode.html and change the lines containing quote_username_open and quote_open to add the font awesome icon syntax and remove the css entry that provides quote.gif. But I must be missing something, because no matter what changes to this ...