Search found 27 matches

by Fyorl
Sat Jul 07, 2012 6:51 pm
Forum: [3.x][Archive] RFCs
Topic: [RFC] Dynamic includes in templates like {FOO}/other/stuff
Replies: 10
Views: 9194

Re: [RFC] Dynamic includes in templates like {FOO}/other/stu

There may be reasons to allow variables in the path but so far I am not seeing any arguments why we should do so. <!-- INCLUDEJS {T_ASSETS_PATH}/javascript/plupload.js --> for example. As for the connection between absolute/relative paths and usage of variables. There is no connection except that w...
by Fyorl
Sat Jul 07, 2012 4:44 pm
Forum: [3.x][Archive] RFCs
Topic: [RFC] Dynamic includes in templates like {FOO}/other/stuff
Replies: 10
Views: 9194

Re: [RFC] Dynamic includes in templates like {FOO}/other/stu

compile_tag_include_php doesn't appear to use get_varref at all and so will simply try to include the path passed to it verbatim. Is this desired, should there be some functionality for INCLUDEPHP to process paths like a/{FOO}/b/{BAR} ? I don't think it will hurt to have this extra functionality eve...
by Fyorl
Fri Jul 06, 2012 10:19 pm
Forum: [3.1/Ascraeus] Merged RFCs
Topic: [RFC] Multiple file uploads
Replies: 76
Views: 88190

Re: [RFC] Multiple file uploads

*Daniel wrote:Thats a shame, other question, can dyou download a diff file from git? or not?
You should be able to use git to pull anyone's branch into your local repo.
by Fyorl
Fri Jul 06, 2012 10:18 pm
Forum: [3.x][Archive] RFCs
Topic: [RFC] Dynamic includes in templates like {FOO}/other/stuff
Replies: 10
Views: 9194

[RFC] Dynamic includes in templates like {FOO}/other/stuff

My PR over here was originally intended to allow INCLUDEJS to include files outside of the style's template directory. I discovered the reason it was not generating file paths outside of the directory was not because of any hard-coded restriction but simply because any paths in any <!-- INCLUDE --> ...
by Fyorl
Mon Jun 18, 2012 3:43 pm
Forum: [3.1/Ascraeus] Merged RFCs
Topic: [RFC] Multiple file uploads
Replies: 76
Views: 88190

Re: [RFC] Multiple file uploads

Plupload is fully integrated now as far as I can tell. Any feedback on additional features is welcome; the PR can be found here: https://github.com/phpbb/phpbb3/pull/833 Once any new features are added I'll try to write some tests and then move on to the 'download all files in this post' and 'downlo...
by Fyorl
Sun Jun 17, 2012 10:30 pm
Forum: [3.1/Ascraeus] Merged RFCs
Topic: [RFC|Merged] Javascript Coding Style
Replies: 17
Views: 21446

[RFC] Coding guidelines - JavaScript braces

I'd like to revisit the discussion on curly braces in Javascript since it didn't seem to get resolved in the previous pages. It was already established that braces on their own line looked ugly for anonymous functions and also caused bugs/errors when attempting to return an object. In this case, it ...
by Fyorl
Sun Jun 17, 2012 7:45 pm
Forum: [3.1/Ascraeus] Merged RFCs
Topic: [RFC] Multiple file uploads
Replies: 76
Views: 88190

Re: [RFC] Multiple file uploads

Sounds good to me.
by Fyorl
Sat Jun 16, 2012 6:16 pm
Forum: [3.1/Ascraeus] Merged RFCs
Topic: [RFC] Multiple file uploads
Replies: 76
Views: 88190

Re: [RFC] Multiple file uploads

I've currently written code to have the client use alert() when the server responds with an error in the middle of uploading one of the files. This effectively pauses the uploads until the user clicks ok. Is this desired behaviour? I feel it might be preferable to have the icon next to the file indi...
by Fyorl
Sat Jun 09, 2012 4:37 pm
Forum: [3.1/Ascraeus] Merged RFCs
Topic: [RFC] Multiple file uploads
Replies: 76
Views: 88190

Re: [RFC] Multiple file uploads

I prefer them on the left because then it's easy to see if you've accidentally missed a comma. I didn't realise the coding guidelines covered JS but I'll change them to whatever is correct.
by Fyorl
Sat Jun 09, 2012 3:17 pm
Forum: [3.1/Ascraeus] Merged RFCs
Topic: [RFC] Multiple file uploads
Replies: 76
Views: 88190

Re: [RFC] Multiple file uploads

The feature branch for this is over here: https://github.com/Fyorl/phpbb3/tree/feature/attachment-improvements Here is the current plupload configuration: $('#attach-panel .inner').pluploadQueue({ runtimes: 'html5' , url: 'upload.php' , max_file_size: '10mb' , chunk_size: '1mb' , unique_names: true ...