Search found 22 matches

by dhruv.goel92
Sat Jun 30, 2012 8:53 pm
Forum: [3.x] Discussion
Topic: Keep search query when search returns no results
Replies: 22
Views: 13068

Re: Keep search query when search returns no results

So a notice saying "You requested page X but there are only Y pages in this result set, page Y is shown" or redirection to the last valid page?
by dhruv.goel92
Mon Jun 25, 2012 4:06 pm
Forum: [3.x] Discussion
Topic: Keep search query when search returns no results
Replies: 22
Views: 13068

Re: Keep search query when search returns no results

We can in that case display a link to the last page perhaps with the error something like " This page was not found/deleted" Click Here to go back to page 1 ?
by dhruv.goel92
Sat Jun 23, 2012 8:57 pm
Forum: [3.x] Discussion
Topic: Keep search query when search returns no results
Replies: 22
Views: 13068

Re: Keep search query when search returns no results

What should be the correct thing to do in case user tries to go to a result page which doesn't exist by changing start = parameter in the link,
an error like - "This Search Result Page is not valid" ? or maybe redirection to the last result page?
by dhruv.goel92
Wed Jun 20, 2012 11:28 am
Forum: [3.x] Discussion
Topic: Keep search query when search returns no results
Replies: 22
Views: 13068

Keep search query when search returns no results

Currently when No results are found for a search query, trigger_error function is called which results in search box being empty.
The search box in my opinion should contain the keywords even if no results were found.
by dhruv.goel92
Fri Jun 15, 2012 9:20 pm
Forum: [3.x][Archive] RFCs
Topic: [GSoC] Search Backend Refactoring
Replies: 18
Views: 21961

Re: [GSoC] Search Backend Refactoring

Documentation for + and - support is present in advanced search much like in mysql fulltext. Incase of no match currently use trigger_error because of which search box is cleared. Should i modify this to actually show the search term? Rest things mentioned above have already been resolved or are i a...
by dhruv.goel92
Fri Jun 08, 2012 3:57 pm
Forum: [3.x][Archive] RFCs
Topic: [GSoC] Search Backend Refactoring
Replies: 18
Views: 21961

Re: [GSoC] Search Backend Refactoring

Yes i have included the ticket number in the commit messages.
by dhruv.goel92
Wed Jun 06, 2012 7:46 pm
Forum: [3.x][Archive] RFCs
Topic: [GSoC] Search Backend Refactoring
Replies: 18
Views: 21961

Re: [GSoC] Search Backend Refactoring

PostgreSQL Branch working for new install as well as on updating to 3.1 [https://github.com/dhruvgoel92/phpbb3/t ... ext-search]
getting Sphinx Search is still on , once done we will have an idea how to proceed further as oleg said.
by dhruv.goel92
Fri Apr 27, 2012 7:01 am
Forum: [3.x][Archive] RFCs
Topic: [GSoC] Search Backend Refactoring
Replies: 18
Views: 21961

[GSoC] Search Backend Refactoring

Motivation for Proposal/ Goal Improving and Extending the PHPBB Search Backend will provide faster and more efficient search capability. It will also make the interface more user friendly by introducing filters. Open Source Search backends like- Sphinx, Lucene are very important for forums which ha...
by dhruv.goel92
Thu Apr 05, 2012 4:41 am
Forum: [3.x] Rejected RFCs
Topic: [RFC|Replaced] Search Backend Refactoring
Replies: 13
Views: 26666

Re: [RFC|Accepted] Search Backend Refactoring

Perhaps we could introduce unit tests for search ?
by dhruv.goel92
Thu Mar 29, 2012 2:26 pm
Forum: [3.1/Ascraeus] Merged RFCs
Topic: [RFC|Merged] Ability to delete auto login keys
Replies: 17
Views: 32506

Re: [RFC|Accepted] Ability to delete auto login keys

I have made a PR. If some could take a look and suggest improvements if any.
One improvement i thought of adding was to highlight the current sessions key.

https://github.com/phpbb/phpbb3/pull/652