Search found 367 matches

by JoshyPHP
Sun Jan 22, 2017 1:14 pm
Forum: [3.2/Rhea] Merged RFCs
Topic: [RFC] Integrate s9e\TextFormatter
Replies: 168
Views: 143839

Re: [RFC] Integrate s9e\TextFormatter

Kind of neither. I discovered that phpBB would allow two custom BBCodes of the same name if exactly one of them used a parameter a good 2 years after finishing the implementation. Since then I haven't really seen any real-world example of such a pair of BBCodes. There's a ticket there: https://track...
by JoshyPHP
Tue Jan 10, 2017 5:18 pm
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-14985 - Plain text is stored as HTML and not decoded before usage
Replies: 1
Views: 3295

Re: PHPBB3-14985 - Plain text is stored as HTML and not decoded before usage

Posted a PR, I'd appreciate if someone with a fresh pair of eyes would take a look: https://github.com/phpbb/phpbb/pull/4631 Some test fixtures I created in previous PRs may be incorrect in that their entities may not be encoded. Most of the time I manually copy/paste data from phpMyAdmin into the X...
by JoshyPHP
Tue Jan 10, 2017 4:42 pm
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-14985 - Plain text is stored as HTML and not decoded before usage
Replies: 1
Views: 3295

PHPBB3-14985 - Plain text is stored as HTML and not decoded before usage

Some reports about issues with HTML special characters in 3.2 have appeared recently: http://area51.phpbb.com/phpBB/viewtopic.php?f=126&t=50811 https://www.phpbb.com/community/viewtopic.php?f=556&t=2400886 The problem is the same for both: admin-submitted text is encoded and stored as HTML, then it...
by JoshyPHP
Mon Jan 09, 2017 4:57 pm
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-14740 BBCode still parses wrong
Replies: 19
Views: 17040

Re: PHPBB3-14740 BBCode still parses wrong

neufke wrote:
Mon Jan 09, 2017 4:46 pm
[law="PUT-A-VERY-LONG-NUMBER-HERE"]Insert lawtext[/law]
Sure, you can do that regardless of the BBCode definition. The only issue here is on the "admin" side. Just do not use quotes in the "BBCode usage" box in the ACP and the BBCode will work with or without quotes in posts.
by JoshyPHP
Mon Jan 09, 2017 4:27 pm
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-14740 BBCode still parses wrong
Replies: 19
Views: 17040

Re: PHPBB3-14740 BBCode still parses wrong

Yes, I can reproduce it on my 3.2.0 board. I've just submitted a fix. In the mean time you can update your BBCode definition to remove the the quotes. [mod={TEXT1}]{TEXT2}[/mod] Note that unlike 3.1, using quotes in the BBCode usage does not mean that users will have to use quotes. Whether or not yo...
by JoshyPHP
Mon Jan 09, 2017 2:27 pm
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-14740 BBCode still parses wrong
Replies: 19
Views: 17040

Re: PHPBB3-14740 BBCode still parses wrong

I thought you were talking about posts submitted on 3.2 but before 3.2.0. Try posting your BBCode definition and the steps to reproduce that issue because I can't reproduce it on my test board.
by JoshyPHP
Mon Jan 09, 2017 1:46 pm
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-14740 BBCode still parses wrong
Replies: 19
Views: 17040

Re: PHPBB3-14740 BBCode still parses wrong

Now, what's the best course of action? Edit the old posts and re-save them so they get reparsed. You may need to add a non-space character to the post to force the update. There isn't an easy way to force a single post to get reparsed currently. If you have many of those you may try the command lin...
by JoshyPHP
Sat Dec 17, 2016 2:07 pm
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-13803 / PHPBB3-13891 - Reparsing text
Replies: 65
Views: 58900

Re: PHPBB3-13803 / PHPBB3-13891 - Reparsing text

The issue is the same: I don't see any benefit to introducing new modes. As far as I'm aware there are only 3 values ever used for $mode in phpBB 3.2: "post", "sig" and since 3.2, "reparse". I think it's safer to ditch "reparse" and just keep the two known ones.
by JoshyPHP
Sat Dec 17, 2016 12:09 pm
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-13803 / PHPBB3-13891 - Reparsing text
Replies: 65
Views: 58900

Re: PHPBB3-13803 / PHPBB3-13891 - Reparsing text

If you use the plugin's name as mode, be aware than the plugin that reparses users signatures is named user_signature whereas the mode used when editing a signature the conventional way is sig. Same for post_text and post.
by JoshyPHP
Sat Dec 17, 2016 11:44 am
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-13803 / PHPBB3-13891 - Reparsing text
Replies: 65
Views: 58900

Re: PHPBB3-13803 / PHPBB3-13891 - Reparsing text

I wouldn't recommend setting it to the plugin's name. As far as I know, only 2 values are ever used for that parameter outside of the reparser: "post" and "sig". Keeping it that way would be the safe option.