Search found 366 matches

by JoshyPHP
Thu Dec 13, 2012 11:48 pm
Forum: [3.x][Archive] RFCs
Topic: [RFC|Accepted] Updated BBcode engine
Replies: 146
Views: 100578

Re: [RFC|Accepted] Updated BBcode engine

I don't disagree with displaying an error. Giving the user feedback seems like a good idea indeed, but the parser still has to be able to make out something of the garbled post to handle automated processes such as converting old posts from an older version or from another forum software. I've been ...
by JoshyPHP
Thu Dec 13, 2012 5:11 pm
Forum: [3.x][Archive] RFCs
Topic: [RFC|Accepted] Updated BBcode engine
Replies: 146
Views: 100578

Re: [RFC|Accepted] Updated BBcode engine

There are plenty of cases of bad user-submitted markup. Whenever reasonably possible and if the intent is obvious, I'll try to fix it. If the intent is not obvious to me, I'll defer to the HTML rules if they're simple enough to implement. Otherwise, I'd try to go with whatever makes sense and is sim...
by JoshyPHP
Wed Dec 12, 2012 11:01 pm
Forum: [3.x][Archive] RFCs
Topic: [RFC|Accepted] Updated BBcode engine
Replies: 146
Views: 100578

Re: [RFC|Accepted] Updated BBcode engine

Can't you render the parsed message as XHTML without parsing it as such? Frankly I'd rather not require the end users to balance their BBCode tags, especially when the current implementation doesn't. It seems like an unnecessary loss. I don't understand what you meant in your last sentence. If you u...
by JoshyPHP
Wed Dec 12, 2012 8:55 pm
Forum: [3.x][Archive] RFCs
Topic: [RFC|Accepted] Updated BBcode engine
Replies: 146
Views: 100578

Re: [RFC|Accepted] Updated BBcode engine

It doesn't have to be a hack at all. Optional end tags are part of HTML 5 and they're not limited to <li> so if you want to produce valid HTML you'd have to handle them appropriately. For instance, [p]a[p]b[/p]c[/p] might seem legal for a BBCode parser, but <p>a<p>b</p>c</p> is not valid HTML and it...
by JoshyPHP
Mon Dec 10, 2012 9:51 pm
Forum: [3.x][Archive] RFCs
Topic: [RFC|Accepted] Updated BBcode engine
Replies: 146
Views: 100578

Re: [RFC|Accepted] Updated BBcode engine

Ok, thanks. It would be nice if someone was able to compile a list of desirable characteristics, if not specs, for the current engine or future solution. It would be even better to sort them out as "essentials" (e.g. "needs to allow custom BBCodes" ), "nice-to-haves", and perhaps even features that ...
by JoshyPHP
Mon Dec 10, 2012 9:06 pm
Forum: [3.x][Archive] RFCs
Topic: [RFC|Accepted] Updated BBcode engine
Replies: 146
Views: 100578

Re: [RFC|Accepted] Updated BBcode engine

By the way, are there any existing tests for the current engine? All I see is one test in tests/bbcode/parser_test.php and a few cases in tests/bbcode/url_bbcode_test.php. I've looked into master and develop.
by JoshyPHP
Mon Oct 29, 2012 9:07 pm
Forum: [3.x][Archive] RFCs
Topic: [RFC|Accepted] Updated BBcode engine
Replies: 146
Views: 100578

Re: [RFC|Accepted] Updated BBcode engine

And so to fix the [url][b][url] issue, we would simply blacklist [url] from being a descendant of itself. Yeah, [url] would need to disallow itself and some other tags (anything interactive, such as videos) as descendants. In fact, no tag needs to be a descendant of itself, unless I'm forgetting a ...
by JoshyPHP
Mon Oct 29, 2012 7:52 pm
Forum: [3.x][Archive] RFCs
Topic: [RFC|Accepted] Updated BBcode engine
Replies: 146
Views: 100578

Re: [RFC|Accepted] Updated BBcode engine

IMO we should store a blacklist of tags that cannot be a given tag's child. IMO that's the way to go for a robust implementation. Ideally it would be best to not only control what tags are allowed as children of a given tag, but also which tags are allowed as descendants . For instance, take [b] an...
by JoshyPHP
Fri Oct 26, 2012 9:57 am
Forum: [3.x][Archive] RFCs
Topic: [RFC|Accepted] Updated BBcode engine
Replies: 146
Views: 100578

Re: [RFC|Accepted] Updated BBcode engine

Thanks for the speedy reply. I should mention that I did not land in this topic because I was cruising forums for something to do. I have a Google alert on "bbcode" (mainly because I'm keeping tabs on what users do or want to do with them) which regularly brings me back here, and that's how I ended ...
by JoshyPHP
Wed Oct 24, 2012 2:56 pm
Forum: [3.x][Archive] RFCs
Topic: [RFC|Accepted] Updated BBcode engine
Replies: 146
Views: 100578

Re: [RFC|Accepted] Updated BBcode engine

Could a developer chime in on the desirability of changing the BBCode engine please? In other words, how badly is it needed, if at all? I see that this RFC's ticket is blocking a few issues on JIRA, but nothing big. I think it would be super awesome if somebody could summarize this thread into a new...