Search found 361 matches

by JoshyPHP
Mon Dec 10, 2012 9:06 pm
Forum: [3.x][Archive] RFCs
Topic: [RFC|Accepted] Updated BBcode engine
Replies: 146
Views: 98630

Re: [RFC|Accepted] Updated BBcode engine

By the way, are there any existing tests for the current engine? All I see is one test in tests/bbcode/parser_test.php and a few cases in tests/bbcode/url_bbcode_test.php. I've looked into master and develop.
by JoshyPHP
Mon Oct 29, 2012 9:07 pm
Forum: [3.x][Archive] RFCs
Topic: [RFC|Accepted] Updated BBcode engine
Replies: 146
Views: 98630

Re: [RFC|Accepted] Updated BBcode engine

And so to fix the [url][b][url] issue, we would simply blacklist [url] from being a descendant of itself. Yeah, [url] would need to disallow itself and some other tags (anything interactive, such as videos) as descendants. In fact, no tag needs to be a descendant of itself, unless I'm forgetting a ...
by JoshyPHP
Mon Oct 29, 2012 7:52 pm
Forum: [3.x][Archive] RFCs
Topic: [RFC|Accepted] Updated BBcode engine
Replies: 146
Views: 98630

Re: [RFC|Accepted] Updated BBcode engine

IMO we should store a blacklist of tags that cannot be a given tag's child. IMO that's the way to go for a robust implementation. Ideally it would be best to not only control what tags are allowed as children of a given tag, but also which tags are allowed as descendants . For instance, take [b] an...
by JoshyPHP
Fri Oct 26, 2012 9:57 am
Forum: [3.x][Archive] RFCs
Topic: [RFC|Accepted] Updated BBcode engine
Replies: 146
Views: 98630

Re: [RFC|Accepted] Updated BBcode engine

Thanks for the speedy reply. I should mention that I did not land in this topic because I was cruising forums for something to do. I have a Google alert on "bbcode" (mainly because I'm keeping tabs on what users do or want to do with them) which regularly brings me back here, and that's how I ended ...
by JoshyPHP
Wed Oct 24, 2012 2:56 pm
Forum: [3.x][Archive] RFCs
Topic: [RFC|Accepted] Updated BBcode engine
Replies: 146
Views: 98630

Re: [RFC|Accepted] Updated BBcode engine

Could a developer chime in on the desirability of changing the BBCode engine please? In other words, how badly is it needed, if at all? I see that this RFC's ticket is blocking a few issues on JIRA, but nothing big. I think it would be super awesome if somebody could summarize this thread into a new...
by JoshyPHP
Tue Sep 18, 2012 6:22 am
Forum: [3.x][Archive] RFCs
Topic: [RFC] extending default BBCodes
Replies: 25
Views: 11526

Re: [RFC] extending default BBCodes

BBCode should never compile to invalid HTML, so you'd have to have some way of validating that the [td] tag the user is trying to use is in fact in both a [table] and a [tr] . Would you mind expanding on that? When you say "invalid HTML" I assume you mean "structurally sound" (e.g. no <td> in the m...
by JoshyPHP
Mon Apr 09, 2012 7:00 am
Forum: [3.x][Archive] RFCs
Topic: [RFC] Javascript Preview
Replies: 13
Views: 9509

Re: [RFC] Javascript Preview

AJAX [...] would continually be sending requests to the PHP bbcode parser after each character is typed. I think the first post refers to a normal (one-off) preview, not a "live" preview. As for the rest, while I'm not certain it would be a good idea for phpBB to implement a client-side preview, a ...
by JoshyPHP
Fri Mar 02, 2012 12:57 pm
Forum: [3.1/Ascraeus] Merged RFCs
Topic: [RFC|Merged] Require PHP 5.3
Replies: 67
Views: 57933

Re: [RFC] Require PHP 5.3

Incidentally, php-dev is already talking about EOL'ing 5.3.
by JoshyPHP
Mon Feb 20, 2012 6:10 pm
Forum: [3.x][Archive] RFCs
Topic: [RFC] Make the use of defer mandatory
Replies: 62
Views: 23898

Re: [RFC] Make the use of defer mandatory

Just throwing that out there, have you considered using a third party library such as ControlJS if defer/async doesn't pan out?
by JoshyPHP
Thu Jan 19, 2012 7:59 pm
Forum: [3.x] Discussion
Topic: Forums depending on users language
Replies: 15
Views: 10025

Re: Forums depending on users language

Actually it's a pretty nice idea, it just needs a good way to be implemented. Take Gentoo's forums , they have a bunch of English-speaking forums at the top, they have a pretty extensive list of international forums in Chinese, Dutch, Finnish, etc... The list is pretty long and most users would prob...