Search found 353 matches

by JoshyPHP
Wed Dec 12, 2012 8:55 pm
Forum: [3.x][Archive] RFCs
Topic: [RFC|Accepted] Updated BBcode engine
Replies: 146
Views: 86556

Re: [RFC|Accepted] Updated BBcode engine

It doesn't have to be a hack at all. Optional end tags are part of HTML 5 and they're not limited to <li> so if you want to produce valid HTML you'd have to handle them appropriately. For instance, [p]a[p]b[/p]c[/p] might seem legal for a BBCode parser, but <p>a<p>b</p>c</p> is not valid HTML and it...
by JoshyPHP
Mon Dec 10, 2012 9:51 pm
Forum: [3.x][Archive] RFCs
Topic: [RFC|Accepted] Updated BBcode engine
Replies: 146
Views: 86556

Re: [RFC|Accepted] Updated BBcode engine

Ok, thanks. It would be nice if someone was able to compile a list of desirable characteristics, if not specs, for the current engine or future solution. It would be even better to sort them out as "essentials" (e.g. "needs to allow custom BBCodes" ), "nice-to-haves", and perhaps even features that ...
by JoshyPHP
Mon Dec 10, 2012 9:06 pm
Forum: [3.x][Archive] RFCs
Topic: [RFC|Accepted] Updated BBcode engine
Replies: 146
Views: 86556

Re: [RFC|Accepted] Updated BBcode engine

By the way, are there any existing tests for the current engine? All I see is one test in tests/bbcode/parser_test.php and a few cases in tests/bbcode/url_bbcode_test.php. I've looked into master and develop.
by JoshyPHP
Mon Oct 29, 2012 9:07 pm
Forum: [3.x][Archive] RFCs
Topic: [RFC|Accepted] Updated BBcode engine
Replies: 146
Views: 86556

Re: [RFC|Accepted] Updated BBcode engine

And so to fix the [url][b][url] issue, we would simply blacklist [url] from being a descendant of itself. Yeah, [url] would need to disallow itself and some other tags (anything interactive, such as videos) as descendants. In fact, no tag needs to be a descendant of itself, unless I'm forgetting a ...
by JoshyPHP
Mon Oct 29, 2012 7:52 pm
Forum: [3.x][Archive] RFCs
Topic: [RFC|Accepted] Updated BBcode engine
Replies: 146
Views: 86556

Re: [RFC|Accepted] Updated BBcode engine

IMO we should store a blacklist of tags that cannot be a given tag's child. IMO that's the way to go for a robust implementation. Ideally it would be best to not only control what tags are allowed as children of a given tag, but also which tags are allowed as descendants . For instance, take [b] an...
by JoshyPHP
Fri Oct 26, 2012 9:57 am
Forum: [3.x][Archive] RFCs
Topic: [RFC|Accepted] Updated BBcode engine
Replies: 146
Views: 86556

Re: [RFC|Accepted] Updated BBcode engine

Thanks for the speedy reply. I should mention that I did not land in this topic because I was cruising forums for something to do. I have a Google alert on "bbcode" (mainly because I'm keeping tabs on what users do or want to do with them) which regularly brings me back here, and that's how I ended ...
by JoshyPHP
Wed Oct 24, 2012 2:56 pm
Forum: [3.x][Archive] RFCs
Topic: [RFC|Accepted] Updated BBcode engine
Replies: 146
Views: 86556

Re: [RFC|Accepted] Updated BBcode engine

Could a developer chime in on the desirability of changing the BBCode engine please? In other words, how badly is it needed, if at all? I see that this RFC's ticket is blocking a few issues on JIRA, but nothing big. I think it would be super awesome if somebody could summarize this thread into a new...
by JoshyPHP
Tue Sep 18, 2012 6:22 am
Forum: [3.x][Archive] RFCs
Topic: [RFC] extending default BBCodes
Replies: 25
Views: 9930

Re: [RFC] extending default BBCodes

BBCode should never compile to invalid HTML, so you'd have to have some way of validating that the [td] tag the user is trying to use is in fact in both a [table] and a [tr] . Would you mind expanding on that? When you say "invalid HTML" I assume you mean "structurally sound" (e.g. no <td> in the m...
by JoshyPHP
Mon Apr 09, 2012 7:00 am
Forum: [3.x][Archive] RFCs
Topic: [RFC] Javascript Preview
Replies: 13
Views: 8320

Re: [RFC] Javascript Preview

AJAX [...] would continually be sending requests to the PHP bbcode parser after each character is typed. I think the first post refers to a normal (one-off) preview, not a "live" preview. As for the rest, while I'm not certain it would be a good idea for phpBB to implement a client-side preview, a ...
by JoshyPHP
Fri Mar 02, 2012 12:57 pm
Forum: [3.1/Ascraeus] Merged RFCs
Topic: [RFC|Merged] Require PHP 5.3
Replies: 67
Views: 51390

Re: [RFC] Require PHP 5.3

Incidentally, php-dev is already talking about EOL'ing 5.3.