Search found 353 matches

by JoshyPHP
Mon Jan 09, 2017 4:27 pm
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-14740 BBCode still parses wrong
Replies: 19
Views: 9461

Re: PHPBB3-14740 BBCode still parses wrong

Yes, I can reproduce it on my 3.2.0 board. I've just submitted a fix. In the mean time you can update your BBCode definition to remove the the quotes. [mod={TEXT1}]{TEXT2}[/mod] Note that unlike 3.1, using quotes in the BBCode usage does not mean that users will have to use quotes. Whether or not yo...
by JoshyPHP
Mon Jan 09, 2017 2:27 pm
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-14740 BBCode still parses wrong
Replies: 19
Views: 9461

Re: PHPBB3-14740 BBCode still parses wrong

I thought you were talking about posts submitted on 3.2 but before 3.2.0. Try posting your BBCode definition and the steps to reproduce that issue because I can't reproduce it on my test board.
by JoshyPHP
Mon Jan 09, 2017 1:46 pm
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-14740 BBCode still parses wrong
Replies: 19
Views: 9461

Re: PHPBB3-14740 BBCode still parses wrong

Now, what's the best course of action? Edit the old posts and re-save them so they get reparsed. You may need to add a non-space character to the post to force the update. There isn't an easy way to force a single post to get reparsed currently. If you have many of those you may try the command lin...
by JoshyPHP
Sat Dec 17, 2016 2:07 pm
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-13803 / PHPBB3-13891 - Reparsing text
Replies: 65
Views: 46338

Re: PHPBB3-13803 / PHPBB3-13891 - Reparsing text

The issue is the same: I don't see any benefit to introducing new modes. As far as I'm aware there are only 3 values ever used for $mode in phpBB 3.2: "post", "sig" and since 3.2, "reparse". I think it's safer to ditch "reparse" and just keep the two known ones.
by JoshyPHP
Sat Dec 17, 2016 12:09 pm
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-13803 / PHPBB3-13891 - Reparsing text
Replies: 65
Views: 46338

Re: PHPBB3-13803 / PHPBB3-13891 - Reparsing text

If you use the plugin's name as mode, be aware than the plugin that reparses users signatures is named user_signature whereas the mode used when editing a signature the conventional way is sig. Same for post_text and post.
by JoshyPHP
Sat Dec 17, 2016 11:44 am
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-13803 / PHPBB3-13891 - Reparsing text
Replies: 65
Views: 46338

Re: PHPBB3-13803 / PHPBB3-13891 - Reparsing text

I wouldn't recommend setting it to the plugin's name. As far as I know, only 2 values are ever used for that parameter outside of the reparser: "post" and "sig". Keeping it that way would be the safe option.
by JoshyPHP
Sat Dec 17, 2016 11:33 am
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-13803 / PHPBB3-13891 - Reparsing text
Replies: 65
Views: 46338

Re: PHPBB3-13803 / PHPBB3-13891 - Reparsing text

I think that the correct way to do it would be a big overhaul of message_parser and the generate_text_for_* functions into a unified API that supports some sort of contextual configuration that would allow the text to be treated differently depending on whether it's from a post, a signature, etc... ...
by JoshyPHP
Sat Dec 17, 2016 11:09 am
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-13803 / PHPBB3-13891 - Reparsing text
Replies: 65
Views: 46338

Re: PHPBB3-13803 / PHPBB3-13891 - Reparsing text

To any event? That would probably be the wrong way to go at it. What is it you're trying to achieve?
by JoshyPHP
Tue Nov 15, 2016 12:17 am
Forum: [3.x] Discussion
Topic: 3.1.10 markdown
Replies: 5
Views: 2518

Re: 3.1.10 markdown

DavidIQ wrote:
Mon Nov 14, 2016 9:36 pm
Pretty sure it's possible to do this with the new text parser in 3.2 without having to edit files.
You can use an extension to enable the Litedown plugin which provides most of Markdown at the document level. It cannot be constrained to an hypothetical [md] BBCode.
by JoshyPHP
Sun Nov 06, 2016 12:28 pm
Forum: [3.2/Rhea] Merged RFCs
Topic: [RFC] Integrate s9e\TextFormatter
Replies: 168
Views: 100711

Re: [RFC] Integrate s9e\TextFormatter

No, there's no such setting. Why do you need the old format?