Search found 353 matches

by JoshyPHP
Tue Mar 28, 2017 10:43 pm
Forum: [3.x] Style Development
Topic: ICONS - How to handle SVG explained
Replies: 16
Views: 9897

Re: ICONS - How to handle SVG explained

These would then be included into the template header just after the body tag. That would mean that every icon would be included in every page. How about storing it in a static file? You can still reference the symbols via xlink, e.g. <svg class="o-icon" aria-hidden="true"> <use xlink:href="/path/t...
by JoshyPHP
Tue Mar 28, 2017 10:12 pm
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-14740 BBCode still parses wrong
Replies: 19
Views: 9424

Re: PHPBB3-14740 BBCode still parses wrong

The PR mentions it was superseded (replaced) by that one: https://github.com/phpbb/phpbb/pull/4631

I think it was merged after 3.2.0 was released, can't recall exactly.
by JoshyPHP
Sat Mar 04, 2017 7:56 pm
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-13919 - Syntax highlighting in [code]
Replies: 22
Views: 17639

Re: PHPBB3-13919 - Syntax highlighting in [code]

The extension only loads highlight.js from a CDN without modifying any BBCodes. highlight.js does its own auto-detection, it doesn't require a language hint although I believe it uses it if present. Is there a reason you want to use the language as class name?
by JoshyPHP
Sun Feb 19, 2017 2:28 pm
Forum: [3.2/Rhea] Merged RFCs
Topic: [RFC] Integrate s9e\TextFormatter
Replies: 168
Views: 100534

Re: [RFC] Integrate s9e\TextFormatter

Yes, [code][/code][/code] will produce an empty code block followed by [/code].

You can pair BBCode tags by appending a colon and a unique number to their name, e.g. [code:123][/code][/code:123]

Code: Select all

[/code]
by JoshyPHP
Sun Jan 22, 2017 5:55 pm
Forum: [3.2/Rhea] Merged RFCs
Topic: [RFC] Integrate s9e\TextFormatter
Replies: 168
Views: 100534

Re: [RFC] Integrate s9e\TextFormatter

You can be useful by handling the PR from start to finish. The best way to handle multiple BBCode definitions with the same name may be to replace them with a definition that covers both use case, and do so as a migration. So far I've seen two different use cases: The [url] BBCode requires a value f...
by JoshyPHP
Sun Jan 22, 2017 1:14 pm
Forum: [3.2/Rhea] Merged RFCs
Topic: [RFC] Integrate s9e\TextFormatter
Replies: 168
Views: 100534

Re: [RFC] Integrate s9e\TextFormatter

Kind of neither. I discovered that phpBB would allow two custom BBCodes of the same name if exactly one of them used a parameter a good 2 years after finishing the implementation. Since then I haven't really seen any real-world example of such a pair of BBCodes. There's a ticket there: https://track...
by JoshyPHP
Tue Jan 10, 2017 5:18 pm
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-14985 - Plain text is stored as HTML and not decoded before usage
Replies: 1
Views: 2436

Re: PHPBB3-14985 - Plain text is stored as HTML and not decoded before usage

Posted a PR, I'd appreciate if someone with a fresh pair of eyes would take a look: https://github.com/phpbb/phpbb/pull/4631 Some test fixtures I created in previous PRs may be incorrect in that their entities may not be encoded. Most of the time I manually copy/paste data from phpMyAdmin into the X...
by JoshyPHP
Tue Jan 10, 2017 4:42 pm
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-14985 - Plain text is stored as HTML and not decoded before usage
Replies: 1
Views: 2436

PHPBB3-14985 - Plain text is stored as HTML and not decoded before usage

Some reports about issues with HTML special characters in 3.2 have appeared recently: http://area51.phpbb.com/phpBB/viewtopic.php?f=126&t=50811 https://www.phpbb.com/community/viewtopic.php?f=556&t=2400886 The problem is the same for both: admin-submitted text is encoded and stored as HTML, then it...
by JoshyPHP
Mon Jan 09, 2017 4:57 pm
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-14740 BBCode still parses wrong
Replies: 19
Views: 9424

Re: PHPBB3-14740 BBCode still parses wrong

neufke wrote:
Mon Jan 09, 2017 4:46 pm
[law="PUT-A-VERY-LONG-NUMBER-HERE"]Insert lawtext[/law]
Sure, you can do that regardless of the BBCode definition. The only issue here is on the "admin" side. Just do not use quotes in the "BBCode usage" box in the ACP and the BBCode will work with or without quotes in posts.