Search found 273 matches

by Ger
Mon Feb 19, 2018 12:59 pm
Forum: [3.x] Discussion
Topic: Quote font is extremely small
Replies: 4
Views: 268

Re: Quote font is extremely small

I'll admit, I haven't visited A51 in a while, so there may be a discussion I missed. Why are quotes showing in small font? I can barely read it. some text I agree. I don't see the benefit of reducing it by 30% (10px vs 13px). Probably because of reducing the used screen space, but I would prefer co...
by Ger
Mon Feb 19, 2018 12:49 pm
Forum: General Development Discussion
Topic: Why does Travis fail?
Replies: 9
Views: 583

Re: Why does Travis fail?

I usually don't have issues when I work from with Netbeans to do work-related stuff with Git and exceed the 79 characters. But we host Git ourselves and don't use Github, so maybe that's different. Also I'm still a bit struggling with the concept of needing to fork phpBB to my own profile, make chan...
by Ger
Tue Feb 13, 2018 11:09 am
Forum: General Development Discussion
Topic: Why does Travis fail?
Replies: 9
Views: 583

Re: Why does Travis fail?

Well, Marc helped me trough IRC. I did exactly as he told me to do and Travis still fails.
Marc wrote:I think the error you're getting now might be caused by the web interface itself. no worries, I'll fix it
So I guess there's some work on the testing procedure... Anyway, thanks Marc.
by Ger
Tue Feb 13, 2018 9:32 am
Forum: General Development Discussion
Topic: Why does Travis fail?
Replies: 9
Views: 583

Re: Why does Travis fail?

Urgh.... Travis fails again on the commit line that's greater than 80 characters long: [ticket/15547] Add file object to event core.avatar_driver_upload_move_file_before Jup, 83 characters. The event name and ticket identifier are 58 characters... so I have to stuff any relevant info in 22 character...
by Ger
Tue Feb 13, 2018 8:49 am
Forum: General Development Discussion
Topic: Why does Travis fail?
Replies: 9
Views: 583

Re: Why does Travis fail?

Well, I've just done it through the Github browser interface.

I've closed my original PR and deleted my fork. Now I've recreated the change and did another PR. Fingers crossed... :P
by Ger
Mon Feb 12, 2018 11:28 am
Forum: General Development Discussion
Topic: Why does Travis fail?
Replies: 9
Views: 583

Re: Why does Travis fail?

Than can you please explain me how to fix this commit message?

I've made an error indeed while creating the commit but fixed it within a minute or so.
by Ger
Mon Feb 12, 2018 9:05 am
Forum: General Development Discussion
Topic: Why does Travis fail?
Replies: 9
Views: 583

Why does Travis fail?

https://travis-ci.org/phpbb/phpbb/jobs/340383829 I've made a simple PR adding 3 simple lines to an event (3 of them comment). The Travis test fails here: 0.51s$ sh -c "set -x;if [ '$NOTESTS' = '1' -a '$TRAVIS_PULL_REQUEST' != 'false' ]; then git remote set-branches --add origin $TRAVIS_BRANCH && git...
by Ger
Thu Oct 12, 2017 8:08 am
Forum: [3.x] Discussion
Topic: function make_clickable_callback
Replies: 7
Views: 4884

Re: function make_clickable_callback

There was also an extension that dealt with external urls but i ve removed it and i cant figure out which it was. I believe it was Primehalo's "PrimeLinks" extension But i cant figure out how to configure it to do that. Its configured in the listener file. No ACP settings. I couldn't figure out how...
by Ger
Thu Jul 27, 2017 3:13 pm
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-10418 - WYSIWYG Editor/Rich Text Editor
Replies: 453
Views: 275679

Re: PHPBB3-10418 - WYSIWYG Editor/Rich Text Editor

It's about the post that's quoted, isn't it? That already has a post date in a timezone, as stated in my previous post. It's passed as $user->format_date($row['post_time']) so it uses the timezone and formatting for the posting user. When you also pass the unix timestamp to the message parser, you'r...
by Ger
Thu Jul 27, 2017 1:43 pm
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-10418 - WYSIWYG Editor/Rich Text Editor
Replies: 453
Views: 275679

Re: PHPBB3-10418 - WYSIWYG Editor/Rich Text Editor

The quote tag has many features. It has the user, the post id, the time of posting and the user id from where the post came from. unfortunately, though, some are dynamic... Maybe too dynamic (just an expression. Not really). See here: https://github.com/phpbb/phpbb/blob/master/phpBB/phpbb/textforma...