Search found 95 matches

by TerryE
Wed May 11, 2011 1:57 pm
Forum: [3.1/Ascraeus] Merged RFCs
Topic: [RFC|Merged] Improved template engine
Replies: 33
Views: 35955

Re: [RFC|Accepted] Improved template engine

OK, so what you are really talking about is a definite architecture change to the templating system: that is the separation on the data context and the template renderer. The data object contains all of the template data including _tpl_data and _rootref, and the render object uses the data object to...
by TerryE
Wed May 11, 2011 12:47 pm
Forum: [3.x] Discussion
Topic: A small CSS optimisation
Replies: 6
Views: 4390

Re: A small CSS optimisation

OK, let's kill this thread then and cover it as part of the jQuery and Prosilver optimisation discussions. :-)
by TerryE
Wed May 11, 2011 12:39 pm
Forum: [3.x] Discussion
Topic: Use of the append_sid function
Replies: 3
Views: 4267

Re: Use of the append_sid function

Hummm, I need to look at the code and the apache log analysis, but my current view is that it isn't as simple as that. For example, once the sid parameter is set then it seems to be latched, so that subsequent pages have it, even if the <forum cookie prefix>_sid cookie is return as a request header....
by TerryE
Wed May 11, 2011 10:38 am
Forum: [3.1/Ascraeus] Merged RFCs
Topic: [RFC|Merged] Improved template engine
Replies: 33
Views: 35955

Re: [RFC|Accepted] Improved template engine

This broke everything because the template engine expects $this to have template variables, which in the executor/renderer is not the case. Therefore I will be adding a "context" class which will store variables used during template evaluation. Why bother? I had to solve this prob in my own templat...
by TerryE
Wed May 11, 2011 8:43 am
Forum: [3.x] Discussion
Topic: Use of the append_sid function
Replies: 3
Views: 4267

Use of the append_sid function

If you grep " append_sid( " in the source tree then you will see that many URL links within a PHP document explicitly append a SID, despite the use of a cookie to maintain the sid as well. I can't understand the reason for this duplication. OK, I realise that some users can disable cookies and there...
by TerryE
Wed May 11, 2011 8:29 am
Forum: [3.x] Discussion
Topic: A small CSS optimisation
Replies: 6
Views: 4390

Re: A small CSS optimisation

This one isn't quite as simple as I suggested because of the current implementation of styleswitcher.js which is attached to the resize button at the right of the header crumb-trail bar. This currently uses a function setActiveStyleSheet(sheet) to cause the change and this uses the DOM to change the...
by TerryE
Wed Apr 20, 2011 6:07 pm
Forum: General Development Discussion
Topic: Bug Reporting for Language Packs
Replies: 4
Views: 5305

Re: Bug Reporting for Language Packs

Maël, I'd already said that you'd fixed this by return. No my point is about the process and integration of support. IIRC we've recently replaced the old NL database with a new Download->languages page. This new page looks sexy, but from an admin's point of view, personally this is a backward step. ...
by TerryE
Wed Apr 20, 2011 4:06 pm
Forum: General Development Discussion
Topic: Bug Reporting for Language Packs
Replies: 4
Views: 5305

Bug Reporting for Language Packs

I recently submitted a bugrep about a mistranslation, which was then immediately closed with the comment Resolution: Invalid. Please bring this to the attention of the language pack maintainer. Languages other than British English are not maintained by the phpBB team. Surely this practice doesn't ma...
by TerryE
Mon Apr 11, 2011 11:48 am
Forum: [3.x] Discussion
Topic: Optimisation of download/file.php
Replies: 1
Views: 2607

Optimisation of download/file.php

This was a point discussed on another topic: Improving phpBB performance for small installations , but it's really a separate issue which merits forking into its own topic. Whenever possible, the [phpBB] application should correctly negotiate the revalidation protocols for quasi-static content. The ...
by TerryE
Sun Apr 10, 2011 10:13 pm
Forum: [3.x] Discussion
Topic: Improving phpBB performance for small installations
Replies: 34
Views: 20418

Re: Improving phpBB performance for small installations

Yup, I've been looking at the code and had already come to that conclusion.