Search found 12 matches

by topdown
Fri Aug 26, 2011 10:49 pm
Forum: [3.1/Ascraeus] Merged RFCs
Topic: [RFC|Merged] Removal of imagesets
Replies: 79
Views: 73718

Re: Removal of imagesets

You have my vote. ++1
I would love the possibility to sprite all of these icons as they should be.
by topdown
Fri Aug 26, 2011 10:46 pm
Forum: [3.x] Discussion
Topic: Version check
Replies: 7
Views: 5157

Re: Version check

QA = Quality Assurance

Benefits :lol:
Same as you or I get now I assume. ;)
by topdown
Fri Aug 26, 2011 7:50 pm
Forum: [3.1/Ascraeus] Merged RFCs
Topic: [RFC|Accepted] Coding Guideline Modifications
Replies: 79
Views: 82584

Re: [RFC|Accepted] Coding Guideline Modifications

Then why not just return null; ? At the same time, wouldn't t be better to return early. Eg. /** * @param string $str * @return null|string */ function test_returns($str = '') { if(!$str) { return null; } else { return $str; } } Instead of /** * @param string $str * @return null|string */ function t...
by topdown
Fri Aug 26, 2011 5:27 pm
Forum: [3.1/Ascraeus] Merged RFCs
Topic: [RFC|Accepted] Coding Guideline Modifications
Replies: 79
Views: 82584

Re: [RFC|Accepted] Coding Guideline Modifications

I didn't see anything in here about return always returning something.
So I am bringing it up.

The old code base has a lot of return; in it.
It would be better if it always returned something return true;
by topdown
Fri Aug 26, 2011 6:23 am
Forum: [3.x] Discussion
Topic: phpBB3 Reractoring
Replies: 2
Views: 2670

phpBB3 Reractoring

Last week I was working on something in phpBB3 and started looking through the core and structure. Once I was done with the project I was working on I started a fresh copy and went to it with changes that have been in the back of my mind for a while. I was working on a master branch copy as I didn't...
by topdown
Sat Sep 04, 2010 8:25 am
Forum: [3.x] Discussion
Topic: Display - Hook/filter
Replies: 1
Views: 3570

Display - Hook/filter

I'm sure this is nothing new and is probably even in the plan already. These are just my thoughts. I've been playing with something so I can demonstrate how I think the OOP phpBB as far as displaying and hooking into those displays. By displaying I mean anything from posts, to profiles, to profile f...
by topdown
Wed Aug 25, 2010 12:44 am
Forum: [3.1/Ascraeus] Merged RFCs
Topic: [RFC|Merged] Include and use jQuery (originally for 3.2)
Replies: 74
Views: 71747

Re: [RFC] Include and use jQuery

If this is not going to be in the style itself then there needs a way to over write it from the style, so that say, if your version is not what I want I can over ride it and phpBB's is not loaded.
Keep that in mind please. ;)
by topdown
Wed Aug 25, 2010 12:33 am
Forum: [3.x] Discussion
Topic: Front End Load Speed improvements
Replies: 2
Views: 4485

Front End Load Speed improvements

As discussed here http://area51.phpbb.com/phpBB/viewtopic.php?f=75&t=32880 CSS Sprites Extending on it a bit This is a must, the current load speed for the index and other pages with icons would be greatly improved. For instance here there are 28 http requests that could easily be 1 CSS file 1 logo ...
by topdown
Wed Aug 25, 2010 12:15 am
Forum: [3.x] Discussion
Topic: Plugin code integration with core
Replies: 12
Views: 13385

Re: Plugin code integration with core

On the WordPress note, their plug-ins do not go through any kind of validation like phpBB Mod teams do. Their requirements are very basic at best, the readme file and the comment at the top of the main plug-in file which is what the Admin Plug-in page shows for info about the plug-in itself. The rea...
by topdown
Tue Aug 24, 2010 11:46 pm
Forum: [3.x] Discussion
Topic: Mobile browser support
Replies: 17
Views: 21224

Re: Mobile browser support

As a note, if not mentioned, almost all recent smart phone browsers have HTML browser support. Most include CSS3 support with exception of Windows mobile of coarse, unless the user uses an alternative browser which is smart from the word Go! Anyway, CSS3 support minimizes the need for scripts etc......