Search found 147 matches

by Kellanved
Fri Feb 25, 2011 10:58 pm
Forum: [3.x] Discussion
Topic: Upload attachments from a URL
Replies: 3
Views: 12249

Re: Upload attachments from a URL

I see little value in this. Remote avatars are not actually copied to the board server, so the basic assumption ("feature already there for avatars") is faulty. The sole benefit I see is that huge files might be added to a post much quicker by using the bigger bandwidth of servers. In this situation...
by Kellanved
Fri Feb 25, 2011 10:45 pm
Forum: [3.x] Rejected RFCs
Topic: [RFC|Replaced] MOD Installer in 3.1
Replies: 16
Views: 17905

Re: [RFC] MOD Installer in 3.1

The point is not to deny that some MODs need to alter the base code to function, it is the impossibility to support the installation of such MODs. File alterations mean that other MODs might not be installable at all; any automatic installer will fail. A core installer puts the burden of correctness...
by Kellanved
Sat Oct 09, 2010 5:27 pm
Forum: [3.x] Discussion
Topic: Replace download.php src by direct src for inline images
Replies: 9
Views: 9772

Re: Replace download.php src by direct src for inline images

How are IE mime sniffing, flash's cross domain and java GIFAR attacks relevant to these static image types? Sadly, all of these attacks use static images as their vector. MIME header are already processed by mod_mime (and equiv functionality in IIS), so the concept of "enforcing" MIME types (for pn...
by Kellanved
Mon Aug 23, 2010 3:26 pm
Forum: [3.1/Ascraeus] Merged Event Requests
Topic: [RFC] user_add hook
Replies: 10
Views: 24970

Re: [RFC] user_add hook

we could also - shocking - use the same hook twice. With an argument from where in the function it was called.
by Kellanved
Fri Aug 20, 2010 2:01 pm
Forum: [3.x] Rejected Event Requests
Topic: [RFC|Rejected] hook_template_snippet
Replies: 8
Views: 16867

[RFC|Rejected] hook_template_snippet

Name: hook_template_snippet Rationale: It's hard to deploy small markup additions over several templates. This hook enables code to inject code prior to template compilation, allowing MODs to alter several templates without changes to the actual template files. By using includes, these snippets can ...
by Kellanved
Thu Aug 19, 2010 4:04 pm
Forum: [3.x] Rejected Event Requests
Topic: [RFC] hook_link: local URL rewriting
Replies: 4
Views: 10348

[RFC] hook_link: local URL rewriting

Name: hook_link Rationale: : Allow url rewriting for "pretty" URLs, adding GET arguments etc. Input: one array reference with the following fields path : the path from the current document root basename: basename of the script to invoke (can be empty) vars: the query string, as key => value array a...
by Kellanved
Tue May 11, 2010 6:15 pm
Forum: [3.x] Discussion
Topic: BBcode ideas
Replies: 10
Views: 11490

Re: BBcode ideas

Frankly, I don't see the benefit at all. Injecting javascript and CSS is something for the upcoming hooks system, not the bbcode system. It might be an idea to provide a hook for bbcodes requiring server-side actions, but that's as far as it goes. Bottom line: wait for the hook placement call for RF...
by Kellanved
Sun May 09, 2010 10:59 am
Forum: [3.1/Ascraeus] Merged RFCs
Topic: [RFC|Merged] General Hook Architecture of phpBB3.1
Replies: 121
Views: 106282

Re: General Hook Architecture of phpBB3.1

Debug: Unless DEBUG is defined, phpBB will disable any MODs that are triggering errors. MODs are not to use trigger error, but have to call the phpBB_message method instead. This behavior can be overridden. How about exceptions?[/quote] The problem is that trigger error - just like an exception - w...
by Kellanved
Sun May 09, 2010 10:56 am
Forum: [3.x][Archive] RFCs
Topic: [RFC|Accepted] Pre-Compile Template Includes
Replies: 14
Views: 27167

Re: [RFC] Pre-Compile Template Includes

eviL3 wrote: Would there be any way to control the order in which the template code is injected? Would the proposed hook priorities allow that?
Precisely :D
by Kellanved
Mon May 03, 2010 4:00 pm
Forum: [3.x] Discussion
Topic: Load images on demand
Replies: 15
Views: 12930

Re: Load images on demand

I see no reason whatsoever for including such a functionality with the core. Users who really want their board to behave in such a fashion can add such a jquery snippet by themselves just fine - even with 3.0. Note that the bandwidth to be saved is rather marginal - avatars are only loaded once by b...