Search found 30 matches

by ckwalsh
Sat Jan 08, 2011 7:46 am
Forum: [3.x][Archive] RFCs
Topic: [RFC|Accepted] HipHop for PHP compatibility
Replies: 7
Views: 7950

Re: [RFC|Accepted] HipHop for PHP compatibility

I see. I reviewed the diff again and I do have some comments/suggestions. 1. The warnings about unsuitability for production use and dangerousness - why is the script unsuitable for production use and dangerous? Considering that hiphop typically is used in production environments, some more guidanc...
by ckwalsh
Sat Jan 08, 2011 1:03 am
Forum: [3.x][Archive] RFCs
Topic: [RFC|Accepted] HipHop for PHP compatibility
Replies: 7
Views: 7950

[RFC|Accepted] HipHop for PHP compatibility

HipHop for PHP transforms PHP source code into highly optimized C++. It was developed by Facebook and was released as open source in early 2010. HipHop transforms your PHP source code into highly optimized C++ and then compiles it with g++ to build binary files. You keep coding in simpler PHP, then...
by ckwalsh
Sun Aug 01, 2010 8:02 pm
Forum: [3.x][Archive] RFCs
Topic: [RFC] Template procedures
Replies: 27
Views: 16848

Re: [RFC] Template procedures

Agreed.

I don't think the template language should be expanded much further in a core phpBB install, but I think it is important for each tag implemented to be modular, allowing anyone to easily add logic they require or remove logic they don't.
by ckwalsh
Sun Aug 01, 2010 8:33 am
Forum: [3.x][Archive] RFCs
Topic: [RFC] Template procedures
Replies: 27
Views: 16848

Re: [RFC] Template procedures

Just saw this, and it seems rather neat. However, I hope the template system could be expanded to support more complex logic. While html macros are nice, what if I want to add completely new functionality to the template system, such as an automated spriting system, or a handler that performs php lo...
by ckwalsh
Mon Feb 15, 2010 1:54 am
Forum: [3.x] Discussion
Topic: A Couple of things I would like to see if phpbb4
Replies: 26
Views: 19674

Re: A Couple of things I would like to see if phpbb4

1) A 'Shout Box'. Now I know there are many chat mods out there, but I find they are just too big and take up too much space. This 'shout box' sits of the left side of the forum where you can choose to ignore it or use it. I know I would have no need of that, and it would get in the way. 2) A set o...
by ckwalsh
Mon Jan 18, 2010 5:02 am
Forum: [3.x][Archive] RFCs
Topic: [RFC & Patch][Implemented] Coding Guidelines
Replies: 55
Views: 39227

Re: [RFC & Patch] Coding Guidelines

I actually like spaces. it bothers me when I open up a file and it's obvious my tab widths are different from the target width, making the mess unreadable. As for having trouble getting people to use spaces instead, a hook could be setup that would automatically convert tabs to spaces. Problem solve...
by ckwalsh
Sun Dec 27, 2009 6:13 am
Forum: [3.x] Discussion
Topic: BBCode Support
Replies: 8
Views: 6130

Re: BBCode Support

Ah, I misunderstood. I thought you meant having both the parsed copy and original post in the database. Since the parsed copy will doubtless be bigger, it would be a space issue.
by ckwalsh
Sat Dec 26, 2009 5:26 pm
Forum: [3.x] Discussion
Topic: BBCode Support
Replies: 8
Views: 6130

Re: BBCode Support

Overall it sounds excellent, I'm just concerned about this: It stores the bbcode stack of a post in a separate column, leaving the original content untouched. Reparsing all posts is as simple as emptying that column. It will automatically be refilled on viewing a post. Potentially, someone could dou...
by ckwalsh
Sat Dec 26, 2009 8:48 am
Forum: [3.x] Discussion
Topic: BBCode Support
Replies: 8
Views: 6130

BBCode Support

There were some discussions about expanding the BBCode system in phpBB 3.1+ or 4.x, and I was hoping some of these things could be worked out. I have not followed 3.1 development closely, which the bbcode parser may be based on , so I appologize if some of this has already been worked out. Types of ...
by ckwalsh
Wed Dec 16, 2009 12:51 am
Forum: [3.x] Discussion
Topic: Gerrit Code Review System
Replies: 6
Views: 5362

Re: Gerrit Code Review System

Through the way git works you actually keep the information about the author etc. in the history, afterall it's distributed. You don't commit someone elses changes, you commit the merge which keeps history of all merge parents. So there's no issue like that which one has in svn. Ah, I didn't realiz...