Search found 1786 matches

by DavidIQ
Mon Feb 11, 2019 1:36 pm
Forum: General Development Discussion
Topic: UX issue/conflict with topic subscription icon/menu
Replies: 9
Views: 592

Re: UX issue/conflict with topic subscription icon/menu

I think if you're actually trying to go with a more proper UX interaction you would actually not change the text at all and only change the icon. After all that's how checkboxes normally work, right?
by DavidIQ
Mon Feb 04, 2019 5:03 pm
Forum: [3.x] Style Development
Topic: Ideas. Standard Style Improvements.
Replies: 28
Views: 4593

Re: Ideas. Standard Style Improvements.

Actually there is no server load issue you do not load anything but what we load now. You just fetch and load the next page of results either on click of a button or when you scroll past a certain point or what not... I was commenting about loading an entire 400 page topic via some "View all replie...
by DavidIQ
Mon Feb 04, 2019 1:11 pm
Forum: [3.x] Style Development
Topic: Ideas. Standard Style Improvements.
Replies: 28
Views: 4593

Re: Ideas. Standard Style Improvements.

"Load more" for a topic to display posts is, in most cases, probably OK as generally, in my experience, you only go back/forward one or two pages - I am sure that there are exceptions to that which could be catered for with a "Show all" button (although I don't know how that would affect server loa...
by DavidIQ
Mon Feb 04, 2019 10:10 am
Forum: [3.x] Style Development
Topic: Ideas. Standard Style Improvements.
Replies: 28
Views: 4593

Re: Ideas. Standard Style Improvements.

I'm assuming this isn't going to be apied to the actual topics, right?
by DavidIQ
Fri Jan 11, 2019 8:27 pm
Forum: [3.x] Tickets Discussion
Topic: [PHPBB3-15928] Remove support for downloading backups
Replies: 16
Views: 3877

Re: [PHPBB3-15928] Remove support for downloading backups

Well I guess you should ask yourself: under what circumstance would an administrator need to download a database backup from within the ACP through their browser? If it's for convenience then does that make their data safe or does it put them in the same precarious situation that many sites have bee...
by DavidIQ
Thu Jan 03, 2019 10:14 am
Forum: [3.x] Discussion
Topic: The sync function in includes/functions_admin.php
Replies: 2
Views: 1363

Re: The sync function in includes/functions_admin.php

Your code fix is backwards as the group by was used when there is more than one forum_id. However that overall fix would break the query when there is only one forum_id since the topic_id column is not agregated or grouped in that instance. You'd have to exclude it the same way you did the group by ...
by DavidIQ
Fri Dec 21, 2018 12:45 am
Forum: [3.x] Style Development
Topic: Feature request: custom css classes template variable for post in viewtopic
Replies: 9
Views: 2882

Re: Feature request: custom css classes template variable for post in viewtopic

Who said anything about it being bad? I simply said that there are already solutions for whatever it is that you're wanting to do that don't require someone to add additional code to the core to handle this which may not even see the light of day until the next major version (still quite a few month...
by DavidIQ
Thu Dec 20, 2018 6:48 pm
Forum: [3.x] Style Development
Topic: Feature request: custom css classes template variable for post in viewtopic
Replies: 9
Views: 2882

Re: Feature request: custom css classes template variable for post in viewtopic

That won't stop another class from overriding style properties which is what I'm referring to. For instance a background color in your class can be overridden by another class regardless of what you call yours.
by DavidIQ
Thu Dec 20, 2018 5:23 pm
Forum: [3.x] Style Development
Topic: Feature request: custom css classes template variable for post in viewtopic
Replies: 9
Views: 2882

Re: Feature request: custom css classes template variable for post in viewtopic

I mean some of those same points are also relevant to your proposed solution. If you add a class it's possible another extension adds their own class and overrides whatever you're doing in your class and another extension adds a class that overrides that and yet another clears it all and adds a page...