Search found 230 matches

by DavidMJ
Wed Jul 08, 2009 8:06 am
Forum: [3.0/Olympus] Discussion
Topic: Very long running query (600ms): could be security issue
Replies: 4
Views: 5652

Re: Very long running query (600ms): could be security issue

That index will not help. What might help is some sort of partitioning of the table into two tables, one for unapproved messages and one for approved. This would allow the lookups to be much faster but would require us to do a minimal amount of extra work on the PHP side of things...
by DavidMJ
Wed Jul 08, 2009 7:57 am
Forum: [3.0/Olympus] Discussion
Topic: Extending the scope of the phpBB cache
Replies: 13
Views: 14904

Re: Extending the scope of the phpBB cache

The problem with caching language stuff into templates is an interesting one, I know this because I tried to do it a while back for _everything_ (Things like imagesets and our dynamically generated stylesheets). The problem is not with the caching of the data itself but with the cache invalidation, ...
by DavidMJ
Sat Aug 23, 2008 7:13 am
Forum: [3.0/Olympus] Discussion
Topic: commit messages
Replies: 11
Views: 8627

Re: on second thought....

on second thought, if the commit messages looks like this: Revision 8777 davidmj, 08/22/2008 07:00 AM “There are two ways of constructing a software design: One way is to make it so simple that there are obviously no deficiencies, and the other way is to make it so complicated that there are no obv...
by DavidMJ
Mon Aug 04, 2008 5:01 am
Forum: [3.x][Archive] RFCs
Topic: [RFC] Template procedures
Replies: 27
Views: 23864

Re: Template procedures

@APTX: can you prototype some examples where we could use this within our own code at some sort of savings, either complexity or redundancy of code @Acyd Burn: I do not think we should arbitrarily halt development on any area if we see a need exists. For example, it looks like template inheritance i...
by DavidMJ
Sat Aug 02, 2008 3:31 pm
Forum: [3.x][Archive] RFCs
Topic: [RFC] Template procedures
Replies: 27
Views: 23864

Re: Template procedures

a) I suggest a nicer name, like SNIPPET
b) does it make sense to allow us to pass a parameter or no?

Other than that, it looks pretty good.

Btw, any hope of support for arbitrary general expressions in places like DEFINE?
by DavidMJ
Sat Aug 02, 2008 5:39 am
Forum: [3.x][Archive] RFCs
Topic: [RFC] Template procedures
Replies: 27
Views: 23864

Re: Template procedures

naderman wrote:Slowly I'm starting to wonder why we don't just use PHP instead of our own template language?
It would be too easy to cheat and do bad things in template land... They would also be harder to verify by the styles team... Our system is very nice for lots of loops
by DavidMJ
Sun Jul 13, 2008 2:25 am
Forum: [3.0/Olympus] Discussion
Topic: is "fork" a 4-letter word?
Replies: 25
Views: 20606

Re: is "fork" a 4-letter word?

For starters, there is no chance of a core dev being handed a mere diff with no context around it. A huge diff is fine so long as it represents changes that reflect a certain goal, do not expect us to integrate giant patches without knowing to what end you were changing phpBB. Also, I think I am in ...
by DavidMJ
Fri Jul 11, 2008 7:55 pm
Forum: [3.0/Olympus] Discussion
Topic: is "fork" a 4-letter word?
Replies: 25
Views: 20606

Re: is "fork" a 4-letter word?

The following represents my opinion and not that of the phpBB development team, nor the phpBB group What I meant is that I don't exactly see my Inbox nor the bug tracker filled with "here is some code that implements something useful". The best we get are bug fixes that I could have fixed myself. I ...
by DavidMJ
Fri Jul 11, 2008 7:12 pm
Forum: [3.0/Olympus] Discussion
Topic: is "fork" a 4-letter word?
Replies: 25
Views: 20606

Re: is "fork" a 4-letter word?

For now, I will just say this much: Nothing stops anybody from submitting a patch.
by DavidMJ
Mon Jun 23, 2008 7:19 pm
Forum: [3.0/Olympus] Discussion
Topic: ACM Modules
Replies: 64
Views: 137064

Re: ACM Modules

The database should be able to be replicated... What you want to achieve must be done at the ACM layer, how you factor beyond that is up to your own discretion. What you could do is make a new ACM module that depends on the memcache and xcache modules. This way, you can swap around modules at will...