Search found 15 matches

by Sectoid
Fri Dec 21, 2018 12:38 am
Forum: [3.x] Style Development
Topic: Feature request: custom css classes template variable for post in viewtopic
Replies: 9
Views: 7153

Re: Feature request: custom css classes template variable for post in viewtopic

That won't stop another class from overriding style properties which is what I'm referring to. For instance a background color in your class can be overridden by another class regardless of what you call yours. The point of the modification is not to change backgrounds but to make some things possi...
by Sectoid
Thu Dec 20, 2018 6:45 pm
Forum: [3.x] Style Development
Topic: Feature request: custom css classes template variable for post in viewtopic
Replies: 9
Views: 7153

Re: Feature request: custom css classes template variable for post in viewtopic

I mean some of those same points are also relevant to your proposed solution. If you add a class it's possible another extension adds their own class and overrides whatever you're doing in your class and another extension adds a class that overrides that and yet another clears it all and adds a pag...
by Sectoid
Thu Dec 20, 2018 5:10 pm
Forum: [3.x] Style Development
Topic: Feature request: custom css classes template variable for post in viewtopic
Replies: 9
Views: 7153

Re: Feature request: custom css classes template variable for post in viewtopic

hello. This is not the correct place to post this. All feature requests need to be posted to the ideas section of .com https://www.phpbb.com/community/ideas/. This forum is for development discussion of the new style for the software. Sorry! However, I will say this seems like a very useless featur...
by Sectoid
Thu Dec 20, 2018 4:27 pm
Forum: [3.x] Style Development
Topic: Feature request: custom css classes template variable for post in viewtopic
Replies: 9
Views: 7153

Feature request: custom css classes template variable for post in viewtopic

Hi,

I'd like to have a feature that allows extensions to inject custom css classes to styles\prosilver\template\viewtopic_body.html 139.

This would be possible if

Code: Select all

<div id="p{postrow.POST_ID}" class="post 
would be changed to

Code: Select all

<div id="p{postrow.POST_ID}" class="{postrow.CUSTOM_CSS_CLASSES} post 
by Sectoid
Fri Sep 15, 2017 10:59 am
Forum: [3.x] Style Development
Topic: Why script-tags are placed at the bottom of the page in Prosilver?
Replies: 22
Views: 22548

Re: Why script-tags are placed at the bottom of the page in Prosilver?

because you have no idea the skill level of the individual making the customization and weather they understand the difference between sync/async and the fact that the dom needs to be built before you can interact with it. It is safer to put it in the footer as you do not have to plan for any of th...
by Sectoid
Thu Sep 14, 2017 1:57 pm
Forum: [3.x] Style Development
Topic: Why script-tags are placed at the bottom of the page in Prosilver?
Replies: 22
Views: 22548

Re: Why script-tags are placed at the bottom of the page in Prosilver?

I don't understand your theorized mobile example. We already have a responsive style which adapts to screen size all without the use of JavaScript. Doing a non-JS solution sounds like a much better and cleaner approach to me. Bad example from me! By hiding I actually meant collapsible elements. For...
by Sectoid
Thu Sep 14, 2017 11:09 am
Forum: [3.x] Style Development
Topic: Why script-tags are placed at the bottom of the page in Prosilver?
Replies: 22
Views: 22548

Re: Why script-tags are placed at the bottom of the page in Prosilver?

ok yes, but thats hacky ajax and its oneway. It only writes to the DB and tricks the user by changing the interface via js. It not two-way which is a much cleaner way of performing things and safer as well. memberlist.php livesearch seems to be two way. so js browser detection? There are far better...
by Sectoid
Thu Sep 14, 2017 9:04 am
Forum: [3.x] Style Development
Topic: Why script-tags are placed at the bottom of the page in Prosilver?
Replies: 22
Views: 22548

Re: Why script-tags are placed at the bottom of the page in Prosilver?

what are you using the change in class name for? and what do you mean by use the pages ajax? the page has no ajax? :shock: viewforum.php already has AJAX functionality: "Mark topics read" but I'm going to extend this much more. <Body> classname (or rather <html> classname) is needed if I want to hi...
by Sectoid
Thu Sep 14, 2017 12:51 am
Forum: [3.x] Style Development
Topic: Why script-tags are placed at the bottom of the page in Prosilver?
Replies: 22
Views: 22548

Re: Why script-tags are placed at the bottom of the page in Prosilver?

Look there is countless debate on this all over the web, and even more documentation out there as to why/when you should opt for the footer/header. The fact of the matter is that it is done for page rendering/performance reasons. https://stackoverflow.com/a/2105394 https://stackoverflow.com/a/12211...
by Sectoid
Thu Sep 14, 2017 12:17 am
Forum: [3.x] Style Development
Topic: Why script-tags are placed at the bottom of the page in Prosilver?
Replies: 22
Views: 22548

Re: Why script-tags are placed at the bottom of the page in Prosilver?

So you haven't actually run into this issue developing an extension or doing something with phpBB? As long as jQuery is at the bottom I can't do what I want to do. That's why I'd like to see jQuery in the <head> in the next version of the Prosilver. The way jQuery is loaded in prosilver has not cha...