Search found 9 matches

by BadBlock2
Fri Sep 22, 2017 10:39 am
Forum: [3.x] Discussion
Topic: Subfolder system for attachments
Replies: 26
Views: 74300

Re: Subfolder system for attachments

By the way, what if the board gets upgraded from a previous version? Will the existing attachments (all in one folder) still work? The number of subfolders used is configurable, and by default is 0 (no subfolders) So, no transition from 0 to 2 subfolders and thus no use for the existing forums?
by BadBlock2
Fri Sep 22, 2017 1:40 am
Forum: [3.x] Discussion
Topic: Subfolder system for attachments
Replies: 26
Views: 74300

Re: Subfolder system for attachments

rubencm wrote: Thu Sep 21, 2017 8:38 pm I have submitted a pr for this https://github.com/phpbb/phpbb/pull/4968
Interesting, I hope you tested it.
By the way, what if the board gets upgraded from a previous version? Will the existing attachments (all in one folder) still work?
by BadBlock2
Thu Sep 14, 2017 11:48 am
Forum: [3.x] Discussion
Topic: Subfolder system for attachments
Replies: 26
Views: 74300

Re: Subfolder system for attachments

rubencm wrote: Thu Sep 14, 2017 10:38 am I think this is partially solved in 3.3 with the storage system, since some storages allows unlimited files in one "virtual" folder.
Hmm... Can you please provide a bit more information on the matter?
by BadBlock2
Wed Sep 13, 2017 5:52 pm
Forum: [3.x] Discussion
Topic: Subfolder system for attachments
Replies: 26
Views: 74300

Re: Subfolder system for attachments

BC is great, i would probably go for a folder structure by upload date probably or something like that (theoretically this way you can have unlimited number of folders and not "just" 256*256 which sounds a lot, though i'm not convinced that the attachments get distributed equally among th...
by BadBlock2
Wed Sep 13, 2017 4:59 pm
Forum: [3.x] Discussion
Topic: Subfolder system for attachments
Replies: 26
Views: 74300

Re: Subfolder system for attachments

What about the concept itself?
Should I leave it as-is to provide backward compatibility and seamless gradual conversion of the file storage?
by BadBlock2
Wed Sep 13, 2017 4:47 pm
Forum: [3.x] Discussion
Topic: Subfolder system for attachments
Replies: 26
Views: 74300

Re: Subfolder system for attachments

{duplicate}
by BadBlock2
Wed Sep 13, 2017 4:44 pm
Forum: [3.x] Discussion
Topic: Subfolder system for attachments
Replies: 26
Views: 74300

Re: Subfolder system for attachments

> However, probably you'll need to make two different PRs for 3.2 and master (or just do it for master, and make it an extension for 3.2). I'm new to extensions actually, couldn't find events that I could use for this purpose. Attachment filepath generation all seems to be hardcoded in core phpBB. >...
by BadBlock2
Wed Sep 13, 2017 12:47 pm
Forum: [3.x] Discussion
Topic: Subfolder system for attachments
Replies: 26
Views: 74300

Subfolder system for attachments

Referring to this archived topic: http://area51.phpbb.com/phpBB/viewtopic.php?f=108&t=42329 Ok, implemented the change on my phpBB 3.0 board earlier, now porting it to my 3.2 dev instance. My board has already reached 500k attachments, so over a million files in one folder (including thumbnails)...
by BadBlock2
Wed Sep 13, 2017 9:00 am
Forum: [3.x] Discussion
Topic: Should we standardize our page titles
Replies: 5
Views: 18877

Re: Should we standardize our page titles

Second that. "Page title - Sitename " works better.