Search found 30 matches

by posey
Yesterday 7:46 pm
Forum: [3.x] Discussion
Topic: phpBB 3.2.8-RC1 released
Replies: 6
Views: 422

Re: phpBB 3.2.8-RC1 released

Where should I document those?
Or just write a small posts in the Ext Writers forum or something?
by posey
Mon May 20, 2019 9:55 am
Forum: [3.x] Discussion
Topic: Control panel module system
Replies: 26
Views: 20327

Re: Control panel module system

Well, seeing this is targeted for 4.0 that should be fine. I am currently coding against master branch and it's working as intended. One thing to note though, is that the order in which arguments are defined in .yml does not matter, however if you want to define the Xth (say 4) parameter in the clas...
by posey
Tue May 14, 2019 10:47 am
Forum: [3.x] Discussion
Topic: Control panel module system
Replies: 26
Views: 20327

Re: Control panel module system

I quickly spoke with nicofuma, and he says it looks nice. He also brought up a good point about the arguments, as symfony allows "named arguments". This means prefixing them with $ . acp_general: tags: { name: acp } class: \phpbb\cp\item shared: false arguments: $auth: acl_a $icon: cogs $route: acp_...
by posey
Mon May 13, 2019 8:45 pm
Forum: [3.x] Discussion
Topic: Control panel module system
Replies: 26
Views: 20327

Re: Control panel module system

Okay, so I saw a new light :bulb: This way the amount of 'declarations' is minimized. We will have to create all '*cp routes' ourselves and not through a routing.yml file. Which should be better anyways, so we define the prefix (eg, '/admin', '/moderator', '/user'). We will have service declaration ...
by posey
Sun May 05, 2019 10:10 pm
Forum: [3.x] Discussion
Topic: "Normal reasons" for FORM_INVALID which now also apply to login forms.
Replies: 4
Views: 3623

Re: "Normal reasons" for FORM_INVALID which now apply to login forms.

Haven't looked into this issue, also not with 3.2.6 But for your specific question on the !empty() . All variables retrieved through $config['setting'] are returned as strings. All booleans stored in the config table are set to '1' ( true ) or '0' ( false ). !empty('1'); returns true !empty('0'); re...
by posey
Sat May 04, 2019 3:16 pm
Forum: [3.x] Discussion
Topic: phpBB 3.2.7-RC1 released
Replies: 10
Views: 4754

Re: phpBB 3.2.7-RC1 released

A missing event dispatcher caused an internal server error when change topic types
Not sure if these release highlights are used for the final package, but if so: changing*
by posey
Wed Apr 17, 2019 11:13 pm
Forum: [3.x] Discussion
Topic: Control panel module system
Replies: 26
Views: 20327

Re: Control panel module system

I know, that's where we are clear on. But how everything is defined. Cause we have three things: - Routes (eg. /admin/index ) that have to be defined - Controllers (eg. phpbb.admin.controller ) that have to be defined - Lists for the *CP Menu (eg. General, Index, Settings, Board settings) that has t...
by posey
Wed Apr 17, 2019 12:11 pm
Forum: [3.x] Discussion
Topic: OAuth system
Replies: 1
Views: 4145

OAuth system

Currently there are a few issues with the OAuth system and limited possibilities extending it. This has various reasons, but most of them look quite 'easily' fixable, atleast, from the surface. Perhaps I'll retract this statement once I dive into adjusting the code. Uncaught exceptions In the UCP yo...
by posey
Wed Apr 17, 2019 11:34 am
Forum: [3.x] Discussion
Topic: Control panel module system
Replies: 26
Views: 20327

Re: Control panel module system

Well, I am stuck with this. All options I have proposed thusfar have been 'rejected' or refuted (lack of better words), all with good reasons. However, this does mean that I am out of ideas on possible approaches. I am still willing to take this on, but I would need an actual example/set up of how i...
by posey
Tue Apr 02, 2019 5:49 pm
Forum: [3.x] Style Development
Topic: Ideas. Standard Style Improvements.
Replies: 40
Views: 33098

Re: Ideas. Standard Style Improvements.

I do have to say that I like infinite scroll and hate it at the same time. It reminds me of browsers' history list. How I often navigate through forums is scroll, click on a topic / last post link, read it and then "Back". With these infinite scrolls, you end up at the top again and have to find whe...