Search found 164 matches

by CHItA
Mon Sep 09, 2019 6:40 pm
Forum: [3.x] Discussion
Topic: Read-only event variables
Replies: 6
Views: 1677

Re: Read-only event variables

I understand the identifiers. They should probably be static. However, for example forum_data or topic_data is sometimes altered by extensions. I know of extensions (among others some of my/our own) that add (add, not alter) data to an event variable that is available within multiple events in a fi...
by CHItA
Mon Sep 09, 2019 5:04 pm
Forum: [3.x] Discussion
Topic: Read-only event variables
Replies: 6
Views: 1677

Re: Read-only event variables

The bigger question to me is how to implement this functionality to support an easy and clean declaration. Do you already have ideas on how to accomplish this? Well, first of I think we should just start documenting it in some way. Then we can start to think about if actually restricting the modifi...
by CHItA
Sun Sep 08, 2019 10:54 am
Forum: [3.x] Discussion
Topic: Read-only event variables
Replies: 6
Views: 1677

Read-only event variables

There is a problem with our current way of handling events in the core. I think it would be a good idea to restrict certain variables from being modified in certain events. The main problem with the current system is that it event variables can be changed in events where it makes no sense which caus...
by CHItA
Mon May 06, 2019 10:37 am
Forum: [3.x] Discussion
Topic: Control panel module system
Replies: 26
Views: 23973

Re: Control panel module system

I guess you could just start working on moving everything into controllers as it should be fairly straightforward and a big help (also a big task). That way you don't need to wait around for our feedback as we all seem to be uncertain how to properly handle the menu related code this time.
by CHItA
Thu Mar 21, 2019 1:40 pm
Forum: [3.x] Discussion
Topic: [TODOs/BLOCKERs] New Default Theme/Style Backend Requirments
Replies: 2
Views: 8827

Re: [TODOs/BLOCKERs] New Default Theme/Style Backend Requirments

BBCODE parser(s): (#7) CHItA Refactor and clean up. Should only pull from one source for what code to render https://tracker.phpbb.com/browse/PHPBB3-15145?, https://tracker.phpbb.com/browse/PHPBB3-11819. Should pull from the template system via bbcode.html to give style authors completely flexibili...
by CHItA
Sun Feb 24, 2019 5:11 pm
Forum: [3.x] Discussion
Topic: Control panel module system
Replies: 26
Views: 23973

Re: Control panel module system

Okay, let's post an update. There was a valid point made that with a yml approach, it might be possible to completely cache it. While the services are cached, the order is not. So that together with the fact it's rather hard to make a water-proof before/after ordered collection (not to mention with...
by CHItA
Wed Feb 20, 2019 2:24 pm
Forum: [3.x] Discussion
Topic: Control panel module system
Replies: 26
Views: 23973

Re: Control panel module system

I would just get rid of the whole concept of an admin can move modules around. It is fairly pointless, and for example, in case of the ACP it might make handling support requests harder (e.g. the admin moved some module to some place else, and now they cannot find it). My idea implementationwise is ...
by CHItA
Thu Oct 11, 2018 6:09 am
Forum: [3.x] Style Development
Topic: [NEW THEME] 4. JS frameworks & approach
Replies: 61
Views: 66065

Re: [NEW THEME] 4. JS frameworks & approach

I think that for people who are not familiar with JS we would need to document the basic functionalities that are intended to be used by them, so I don't think that Vue completely solves that problem for us. On the other hand, for the style/extension authors who are familiar with JS development I do...
by CHItA
Mon Oct 08, 2018 5:55 pm
Forum: [3.x] Style Development
Topic: [NEW THEME] 4. JS frameworks & approach
Replies: 61
Views: 66065

Re: [NEW THEME] 4. JS frameworks & approach

Sure, however, either way you need to document it in some form how to create a modal or any other component. If we don't use Vue it would be

Code: Select all

<div class="whatever" data-container="modal">your content</div>

Which is not a considerably more difficult concept to understand IMO.
by CHItA
Mon Oct 08, 2018 6:00 am
Forum: [3.x] Style Development
Topic: [NEW THEME] 4. JS frameworks & approach
Replies: 61
Views: 66065

Re: [NEW THEME] 4. JS frameworks & approach

[...] When you think as a novice what is simpler to understand var $modalToggle = '[data-toggle="modal"]'; var $modal = '[data-container="modal"]'; $($modalToggle).click(function(e) { e.preventDefault(); e.stopPropagation(); $($modal).toggleClass("is-active"); }); or something like this <div class=...