Search found 16 matches

by kasimi
Sat Jan 26, 2019 6:24 pm
Forum: General Development Discussion
Topic: notification method is_available() (possible) bug
Replies: 2
Views: 4696

Re: notification method is_available() (possible) bug

This looks like by design to me. The auth instance you get from the container always belongs to the user of the current request. The notification methods simply weren't built with support for user-depending availability in mind. :|
by kasimi
Thu Dec 06, 2018 8:26 am
Forum: General Development Discussion
Topic: Renderer class - why these two variables are different
Replies: 5
Views: 5754

Re: Renderer class - why these two variables are different

mikovchain wrote:
Thu Dec 06, 2018 4:57 am
the variable $renderer equals to $this->renderer
Not quite:

$renderer !== $this->renderer

because

$renderer === $this

therefore

$renderer->renderer === $this->renderer
by kasimi
Tue Nov 27, 2018 9:13 am
Forum: General Development Discussion
Topic: Moving developement discussion to Discord
Replies: 47
Views: 49424

Re: Moving developement discussion to Discord

I'm #3709. The other kasimi #4467 can be removed, that was also me but from a different computer, not sure why I was able to get the same username. Isn't that supposed to be disallowed?
by kasimi
Sun Oct 22, 2017 6:06 pm
Forum: [3.x] Discussion
Topic: Indicate who hasn't read a multi-user PM
Replies: 4
Views: 4049

Re: Indicate who hasn't read a multi-user PM

When viewing a message, adding the unread information is a minor change as there are to_recipient and bcc_recipient blocks being used already. When viewing a folder, the recipient names are just a string, getting joined before being assigned to the template. The function that fetches the names only...
by kasimi
Sun Oct 22, 2017 10:17 am
Forum: [3.x] Discussion
Topic: Indicate who hasn't read a multi-user PM
Replies: 4
Views: 4049

Re: Indicate who hasn't read a multi-user PM

When sending to users (as opposed to groups), the data is already there, it just needs to be displayed. There won't be any performance penalties.

For multi-groups this will not work, just like it isn't working at the moment when sending to a single group. But we've gotta start somewhere. :P
by kasimi
Sun Oct 22, 2017 8:59 am
Forum: [3.x] Discussion
Topic: Indicate who hasn't read a multi-user PM
Replies: 4
Views: 4049

Indicate who hasn't read a multi-user PM

When sending a PM to a single user, you know the user has read them PM when it has been moved from your Outbox to your Sent messages folder. When sending a PM to multiple users, the PM is moved the moment the first user reads it. There is no way to know who the first reader was and who hasn't read t...
by kasimi
Mon Sep 25, 2017 5:01 pm
Forum: [3.x] Discussion
Topic: [RFC] buggy function banned user ids
Replies: 1
Views: 2706

Re: [RFC] buggy function banned user ids

0 is the correct value here because the query is selecting banned users, as opposed to banned emails or IPs for which ban_userid whould be 0. If you change it to <> 1, the returned array contains an invalid entry.
by kasimi
Thu Nov 24, 2016 2:28 pm
Forum: [3.x] Discussion
Topic: Prevent deletion of built-in permission roles
Replies: 3
Views: 3945

Re: Prevent deletion of built-in permission roles

I think the migrator should take care of this. If the role doesn't exist, the permission.permission_set operation should be skipped, without throwing an error. Admins who delete built-in roles should know that extension won't be able to set default permission values. Either that, or don't allow dele...
by kasimi
Fri Sep 23, 2016 5:22 pm
Forum: [3.x] Discussion
Topic: "Mark forums read" can be pressed accidentally in mobile devices
Replies: 11
Views: 10866

Re: "Mark forums read" can be pressed accidentally in mobile devices

There's an extension in [DEV] for this. The confirmation only works with JavaScript enabled though.

https://www.phpbb.com/community/viewtop ... &t=2357461
by kasimi
Mon Feb 23, 2015 6:16 pm
Forum: [3.x][Archive] RFCs
Topic: [RFC] composer phpBB versions and installation
Replies: 16
Views: 15823

Re: [RFC] composer phpBB versions and installation

Add this to your migration. Enabling the extension on any earlier version will fail.

Code: Select all

static public function depends_on()
{
    return array('\phpbb\db\migration\data\v31x\v313');
} 
I'd also be interested in a solution for extensions that don't have migrations.