Search found 13 matches

by kasimi
Sun Oct 22, 2017 6:06 pm
Forum: [3.x] Discussion
Topic: Indicate who hasn't read a multi-user PM
Replies: 4
Views: 371

Re: Indicate who hasn't read a multi-user PM

When viewing a message, adding the unread information is a minor change as there are to_recipient and bcc_recipient blocks being used already. When viewing a folder, the recipient names are just a string, getting joined before being assigned to the template. The function that fetches the names only...
by kasimi
Sun Oct 22, 2017 10:17 am
Forum: [3.x] Discussion
Topic: Indicate who hasn't read a multi-user PM
Replies: 4
Views: 371

Re: Indicate who hasn't read a multi-user PM

When sending to users (as opposed to groups), the data is already there, it just needs to be displayed. There won't be any performance penalties.

For multi-groups this will not work, just like it isn't working at the moment when sending to a single group. But we've gotta start somewhere. :P
by kasimi
Sun Oct 22, 2017 8:59 am
Forum: [3.x] Discussion
Topic: Indicate who hasn't read a multi-user PM
Replies: 4
Views: 371

Indicate who hasn't read a multi-user PM

When sending a PM to a single user, you know the user has read them PM when it has been moved from your Outbox to your Sent messages folder. When sending a PM to multiple users, the PM is moved the moment the first user reads it. There is no way to know who the first reader was and who hasn't read t...
by kasimi
Mon Sep 25, 2017 5:01 pm
Forum: [3.x] Discussion
Topic: [RFC] buggy function banned user ids
Replies: 1
Views: 572

Re: [RFC] buggy function banned user ids

0 is the correct value here because the query is selecting banned users, as opposed to banned emails or IPs for which ban_userid whould be 0. If you change it to <> 1, the returned array contains an invalid entry.
by kasimi
Thu Nov 24, 2016 2:28 pm
Forum: [3.x] Discussion
Topic: Prevent deletion of built-in permission roles
Replies: 3
Views: 1598

Re: Prevent deletion of built-in permission roles

I think the migrator should take care of this. If the role doesn't exist, the permission.permission_set operation should be skipped, without throwing an error. Admins who delete built-in roles should know that extension won't be able to set default permission values. Either that, or don't allow dele...
by kasimi
Fri Sep 23, 2016 5:22 pm
Forum: [3.x] Discussion
Topic: "Mark forums read" can be pressed accidentally in mobile devices
Replies: 11
Views: 5915

Re: "Mark forums read" can be pressed accidentally in mobile devices

There's an extension in [DEV] for this. The confirmation only works with JavaScript enabled though.

https://www.phpbb.com/community/viewtop ... &t=2357461
by kasimi
Mon Feb 23, 2015 6:16 pm
Forum: [3.x][Archive] RFCs
Topic: [RFC] composer phpBB versions and installation
Replies: 16
Views: 8947

Re: [RFC] composer phpBB versions and installation

Add this to your migration. Enabling the extension on any earlier version will fail.

Code: Select all

static public function depends_on()
{
    return array('\phpbb\db\migration\data\v31x\v313');
} 
I'd also be interested in a solution for extensions that don't have migrations.
by kasimi
Wed Jan 21, 2015 11:13 pm
Forum: [3.x] Event Requests
Topic: [Template] search_results_posts_to_advanced_search_after
Replies: 3
Views: 2406

Re: [Template] search_results_posts_to_advanced_search_after

Okay, Iooks good. I'll have to come up with a solution for L13. Thanks so much for your help!
by kasimi
Tue Jan 20, 2015 9:16 pm
Forum: [3.x] Event Requests
Topic: [Template] search_results_posts_to_advanced_search_after
Replies: 3
Views: 2406

[Template] search_results_posts_to_advanced_search_after

I've ported parts of asinshesq 's MOD View or mark unread posts . It needs to add a "Mark forums read" link to the search _ results .html , right below the "Go to advanced search" link. I tried to make things a bit cleaner by moving the event outside of the <p> element but the result didn't look qui...
by kasimi
Tue Jan 20, 2015 9:15 pm
Forum: [3.x] Event Requests
Topic: [PHP] core.get_unread_topics_modify_sql
Replies: 1
Views: 1550

[PHP] core.get_unread_topics_modify_sql

I've ported parts of asinshesq 's MOD View or mark unread posts . The extension needs to modify the SQL query which fetches the unread topics data in the function get_unread_topics() in /includes/functions.php , right after the $sql_array variable is assembled (in 3.1.2 after line 1692). /**  * Chan...