Search found 27 matches

by Fyorl
Sun Nov 11, 2012 9:49 pm
Forum: [3.x][Archive] RFCs
Topic: Replace image buttons with css
Replies: 59
Views: 29857

Re: [RFC] Replace image buttons with css

+1
by Fyorl
Sat Nov 10, 2012 3:25 pm
Forum: [3.x][Archive] RFCs
Topic: [RFC] Autosave
Replies: 28
Views: 16441

Re: [RFC] Autosave

I started work on this, the PR is here: https://github.com/phpbb/phpbb3/pull/1063 Some questions that have cropped up: Do we need to keep track of more than one post at a time? It seems to me that a user will only be working on one post at a time per board. If we want to distinguish posts, how shoul...
by Fyorl
Sun Aug 05, 2012 9:06 pm
Forum: [3.1/Ascraeus] Merged RFCs
Topic: [RFC|Merged] Dependency Injection Container
Replies: 17
Views: 11484

Re: [RFC] Dependency Injection Container

+1 for the acronym
by Fyorl
Thu Aug 02, 2012 5:24 pm
Forum: [3.x] Discussion
Topic: Attachment Downloads
Replies: 41
Views: 20731

Re: [RFC] Attachment Downloads

So it seems tar is always supported but anything else is optional. Seems reasonable.
by Fyorl
Thu Aug 02, 2012 3:38 pm
Forum: [3.x] Discussion
Topic: Attachment Downloads
Replies: 41
Views: 20731

Attachment Downloads

I'm in the process of adding a feature to allow downloading all the attachments in a post and all the attachments in a topic. The files should be archived before the user is prompted for a download but as far as I can tell, none of the archiving libraries is enabled by default in PHP. Should the fea...
by Fyorl
Sun Jul 29, 2012 3:48 pm
Forum: [3.x] Rejected RFCs
Topic: [RFC|Rejected] [API] API functions accept arrays as arguments
Replies: 12
Views: 9080

Re: [RFC] [API] API functions accept arrays as arguments

Don't you lose the ability to do type hinting with this?
by Fyorl
Mon Jul 23, 2012 9:37 am
Forum: [3.x][Archive] RFCs
Topic: [RFC] Add "Tahoma" font
Replies: 25
Views: 13481

Re: [RFC] Add "Tahoma" font

I feel like a good option would be to change the value of font-family in all the stylesheets programmatically. As Arty pointed out, such a change to the core phpBB style would affect everyone using it and Tahoma isn't necessarily the font we'd want to use for say, Roman characters. Such a script wou...
by Fyorl
Sat Jul 21, 2012 12:22 am
Forum: [3.x][Archive] RFCs
Topic: [RFC] Add "Tahoma" font
Replies: 25
Views: 13481

Re: [RFC] Add "Tahoma" font

Is this asking for the actual font file or just font-family: Tahoma; in all the styles?
by Fyorl
Sat Jul 07, 2012 11:30 pm
Forum: [3.x][Archive] RFCs
Topic: [RFC] Dynamic includes in templates like {FOO}/other/stuff
Replies: 10
Views: 6024

Re: [RFC] Dynamic includes in templates like {FOO}/other/stu

The assets_version is already appended by the INCLUDEJS macro. It generates $_template->_js_include and _js_include appends ?assets_version to its argument. Since this modification I proposed still generates $_template->_js_include, this won't be a problem. The PR is over here: https://github.com/ph...
by Fyorl
Sat Jul 07, 2012 7:42 pm
Forum: [3.x][Archive] RFCs
Topic: [RFC] Dynamic includes in templates like {FOO}/other/stuff
Replies: 10
Views: 6024

Re: [RFC] Dynamic includes in templates like {FOO}/other/stu

All JS in the assets directory is currently included with {T_ASSETS_PATH}/javascript/script.js?assets_version={T_ASSETS_VERSION} presently. It seems intuitive to me to just translate that all to <!-- INCLUDEJS {T_ASSETS_PATH}/javascript/script.js -->. I understand that all the javascript in the asse...