Development Discussion Board

Thank you for your reply.
I tried to make the current patch as conservative as possible. So, I don't expect any change in behavior.
if you accept the pull request, more cleanups could be done later, but this one was an easy and safe patch

Hi phpBB team, I opened a pull request on github at https://github.com/phpbb/phpbb/pull/1880 This pull request is an open invitation to use patchwork/utf8 as phpBB's fallback UTF-8 handling implementation. See https://github.com/nicolas-grekas/Patchwork-UTF8 As a quick introduction, patchwork/utf8 i...

Patchwork\Utf8 has reached version 1.1.5, that is, better packaging, especially since the Laravel4 framework made it one of its dependencies.

The subject is detailled and introduced here : http://unicode.org/reports/tr29/ In unicode, a g̈ can be encoded as 2 code point (two UTF-8 chars) : U+0067 LATIN SMALL LETTER G then U+0308 COMBINING DIAERESIS With mb_string, if you do a mb_substr("ag̈u", 1, 2, 'UTF-8'), you'll get a "g...

I should add that on top of the portability given by the PHP implementation, we are of course free to create any abstraction. So if wanted, the current utf8_* functions in phpbb can be kept, but implemented without requiring the current "if mbstring available... else..." that reduce testab...

For the licence, I'm thinking about changing it to APLv2+GPLv2, so if LGPLv3 is a pb, then it might not be anymore very soon. For the technical merit, I don't think phpbb currently handles grapheme clusters, althought that seems important for unicode string handling. My lib does this is a portable w...

The code is here: https://github.com/nicolas-grekas/Patchwork-UTF8 And the quick feature list: - utf-8 handling is extended to grapheme clusters, - any PHP function that needs utf-8 (grapheme cluster) awareness is carefully replicated in my lib with the very same signature (this helps a lot on docum...