Search found 376 matches

by JoshyPHP
Sun Mar 08, 2020 12:21 am
Forum: [3.x] Style Development
Topic: [4.0.x] Chameleon: no more first unread post links
Replies: 16
Views: 2500

Re: [4.0.x] Chameleon: no more first unread post links

Both URLs are already available in templates right now, why would that change in 4.0? Are you all reacting to hypothetical scenarios?
by JoshyPHP
Sat Mar 07, 2020 5:13 pm
Forum: [3.x] Style Development
Topic: [4.0.x] Chameleon: no more first unread post links
Replies: 16
Views: 2500

Re: [4.0.x] Chameleon: no more first unread post links

In that case I would suggest a different approach by turning a negative into a positive. For example, you could say "if the default style does not make it possible to access the first unread post directly, I will create a style that implements it because this is an important feature for me."
by JoshyPHP
Sat Mar 07, 2020 2:08 pm
Forum: [3.x] Style Development
Topic: [4.0.x] Chameleon: no more first unread post links
Replies: 16
Views: 2500

Re: [4.0.x] Chameleon: no more first unread post links

Not upgrading because of a link is like refusing to eat because there's no ketchup on your fries. Editing a template doesn't take much more time than opening the little packet of ketchup that usually goes with the fries. Even if every link on the front page were blinking and all led to a random page...
by JoshyPHP
Tue Mar 03, 2020 9:41 pm
Forum: [3.x] Style Development
Topic: [4.0.x] Chameleon: no more first unread post links
Replies: 16
Views: 2500

Re: [4.0.x] Chameleon: no more first unread post links

As a point of reference: when logged-in, a topic's title in XenForo's "viewforum" page links to the first unread post. There's no special icon to click because it's assumed that most users want to resume reading the topic where they left off. The last post information does link to the last post.
by JoshyPHP
Mon Feb 24, 2020 11:33 pm
Forum: [3.x] Discussion
Topic: DocBlocks
Replies: 15
Views: 11880

Re: DocBlocks

You can use strict_types on new files while preserving compatibility with the less type-aware parts of the codebase.
by JoshyPHP
Sat Dec 07, 2019 11:53 pm
Forum: [3.x] Tickets Discussion
Topic: PHPBB3-16250 - Improve detection of unsafe BBCodes in ACP
Replies: 0
Views: 1939

PHPBB3-16250 - Improve detection of unsafe BBCodes in ACP

https://tracker.phpbb.com/browse/PHPBB3-16250 https://github.com/phpbb/phpbb/pull/5770 Some context: when adding or editing a custom BBCode, the form produces an error if the BBCode is deemed risky. The user is warned but can still create the risky BBCode. The error message mentions the possibility ...
by JoshyPHP
Thu Aug 15, 2019 8:08 pm
Forum: [3.x] Discussion
Topic: Use modern PHP syntax and features in all new code
Replies: 2
Views: 5027

Re: Use modern PHP syntax and features in all new code

phpBB already uses autoloading, just not for everything. There's a couple dozen of old files that need to be loaded manually, most of them are in common.php anyway.
by JoshyPHP
Sun Jun 16, 2019 3:38 am
Forum: [3.x] Discussion
Topic: Use modern PHP syntax and features in all new code
Replies: 2
Views: 5027

Use modern PHP syntax and features in all new code

Now that phpBB requires a contemporary version of PHP, I suggest that the coding guidelines be updated to take advantage of it. For instance, if that's not already the case, all new code should use the short array syntax. All new code should use scalar typing where available and return typing too. P...
by JoshyPHP
Mon May 27, 2019 12:58 am
Forum: [3.x] Discussion
Topic: [Solved]Install the dependencies (4.0.0-a1-dev)
Replies: 8
Views: 7654

Re: Install the dependencies (4.0.0-a1-dev)

You're probably not using PHP 7, somehow. Try php -v.

Although it's weird Composer didn't warn about it. Might be a weird edge case.
by JoshyPHP
Mon Nov 05, 2018 3:29 pm
Forum: [3.x] Discussion
Topic: Future support for Sphinx Search
Replies: 15
Views: 14669

Re: Future support for Sphinx Search

SphinxQL has been around since 0.9.9-rc2 so it should cover any version of Sphinx released this decade.